Re: WPT tests and test guidelines

--000000000000cd6dc405a3d0a57c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

For Skef: First, thank you for your contribution. This does look really
useful. Second, sorry for the slow review; I probably should have at least
un-assigned myself so that the bot would assign someone else. But I didn't
expect that it would take me 2 weeks to get to it. I'm looking at it now &
further comment on the PR itself will happen on GitHub.

But you're right, that this hasn't been a very welcoming experience for
someone trying to help, and that's counterproductive given how much help we
need on testing.

*To the WG: *Planning for testing will need to include better processes for
reviewing test submission.

For starters, we need a refresh of the list of potential reviewers in
https://github.com/web-platform-tests/wpt/blob/master/svg/META.yml
Please add yourself to that list if you can help! (edit the file & submit a
PR =E2=80=94 you can do this from the web UI)

Then, make sure you have email filters set up so you don't miss review
requests or assignments. Tips:
https://help.github.com/en/github/receiving-notifications-about-activity-on=
-github/about-email-notifications

If you get assigned something & you don't have time to work on it, or don't
have the expertise to handle this particular PR, clear the assignment & the
bot will pick a new victim.

But even if you're not assigned, review it if you have time. Make sure it
matches the spec, that it's clear what it is and isn't testing, and so on.
Lots of guidance on the WPT blog: https://web-platform-tests.org/

Of course, coming up with a template & checklist for writing tests, and a
specific =E2=80=9Chow to write SVG tests=E2=80=9D blog post (as we discusse=
d on the last
telcon) will also help reviewers, too.

Any suggestions on how to make this process smoother (for test-writers and
test-reviewers) are very welcome!

~Amelia

On Mon, 20 Apr 2020 at 02:30, Skef Iterum <[email protected]> wrote:

> The primary topic of the minutes of the last SVG WG meeting (
> https://www.w3.org/2020/04/08-svg-minutes.html ) is the problem of
> finding people to implement tests and establishing guidelines for tests.
>
> Meanwhile the vibe over at
> https://github.com/web-platform-tests/wpt/pull/22791 seems more like
> tolerant indifference (although I am very grateful for @fsoder's review).
>
> So maybe some more dots could be connected between these? I am here, I
> have written some tests. I plan to write some more tests, and how many
> could depend on how much interest there is.
>
> Skef
>
>
>
>

--000000000000cd6dc405a3d0a57c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>For Skef: First, thank you for your contribution. Thi=
s does look really useful. Second, sorry for the slow review; I probably sh=
ould have at least un-assigned myself so that the bot would assign someone =
else. But I didn&#39;t expect that it would take me 2 weeks to get to it. I=
&#39;m looking at it now &amp; further comment on the PR itself will happen=
 on GitHub.</div><div><br></div><div>But you&#39;re right, that this hasn&#=
39;t been a very welcoming experience for someone trying to help, and that&=
#39;s counterproductive given how much help we need on testing.</div><div><=
br></div><div><b>To the WG: </b>Planning for testing will need to include b=
etter processes for reviewing test submission.</div><div><br></div><div>For=
 starters, we need a refresh of the list of potential reviewers in=C2=A0<a =
href=3D"https://github.com/web-platform-tests/wpt/blob/master/svg/META.yml"=
>https://github.com/web-platform-tests/wpt/blob/master/svg/META.yml</a></di=
v><div>Please add yourself to that list if you can help! (edit the file &am=
p; submit a PR =E2=80=94 you can do this from the web UI)</div><div><br></d=
iv><div>Then, make sure you have email filters set up so you don&#39;t miss=
 review requests or assignments. Tips:=C2=A0<a href=3D"https://help.github.=
com/en/github/receiving-notifications-about-activity-on-github/about-email-=
notifications">https://help.github.com/en/github/receiving-notifications-ab=
out-activity-on-github/about-email-notifications</a></div><div><br></div><d=
iv>If you get assigned something &amp; you don&#39;t have time to work on i=
t, or don&#39;t have the expertise to handle this particular PR, clear the =
assignment &amp; the bot will pick a new victim.</div><div><br></div><div>B=
ut even if you&#39;re not assigned, review it if you have time. Make sure i=
t matches the spec, that it&#39;s clear what it is and isn&#39;t testing, a=
nd so on. Lots of guidance on the WPT blog:=C2=A0<a href=3D"https://web-pla=
tform-tests.org/">https://web-platform-tests.org/</a></div><div><br></div><=
div>Of course, coming up with a template &amp; checklist for writing tests,=
 and a specific =E2=80=9Chow to write SVG tests=E2=80=9D blog post (as we d=
iscussed on the last telcon) will also help reviewers, too.</div><div><br><=
/div><div>Any suggestions on how to make this process smoother (for test-wr=
iters and test-reviewers) are very welcome!</div><div><br></div><div>~Ameli=
a</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail=
_attr">On Mon, 20 Apr 2020 at 02:30, Skef Iterum &lt;<a href=3D"mailto:gith=
[email protected]">[email protected]</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex">The primary topic of the minutes of the last SV=
G WG meeting ( <br>
<a href=3D"https://www.w3.org/2020/04/08-svg-minutes.html" rel=3D"noreferre=
r" target=3D"_blank">https://www.w3.org/2020/04/08-svg-minutes.html</a> ) i=
s the problem of <br>
finding people to implement tests and establishing guidelines for tests.<br=
>
<br>
Meanwhile the vibe over at <br>
<a href=3D"https://github.com/web-platform-tests/wpt/pull/22791" rel=3D"nor=
eferrer" target=3D"_blank">https://github.com/web-platform-tests/wpt/pull/2=
2791</a> seems more like <br>
tolerant indifference (although I am very grateful for @fsoder&#39;s review=
).<br>
<br>
So maybe some more dots could be connected between these? I am here, I <br>
have written some tests. I plan to write some more tests, and how many <br>
could depend on how much interest there is.<br>
<br>
Skef<br>
<br>
<br>
<br>
</blockquote></div>

--000000000000cd6dc405a3d0a57c--