Re: [SCXML] bad tests with inline values

Hi,

Perhaps also mentioning the test cases where the current definition is
creating difficulty:

test179.scxml:
 * data definition : <content>123</content>
 * equality test : <transition cond="_event.data == '123'" ... ( should be
<transition cond="_event.data == 123")

test529.scxml:
 * data definition : <content>21</content>
 * equality test :<transition cond="_event.data == '21'" ... ( should be
<transition cond="_event.data == 21" )

If the change is made, we could probably return to strict equality ( === )
tests instead of ==.

Thanks,
Zjnue


On Tue, Mar 18, 2014 at 1:51 PM, Jim Barnett <[email protected]> wrote:

> What do other people think of this proposal?  I'm willing to make the
> change but don't understand how/if it might effect other platforms.
>
> - Jim
>
> On 3/17/2014 8:47 PM, Zjnue Brzavi wrote:
>
>> Hi,
>>
>> I'd like to propose a change to the eventdataVal XSL definition.
>> Right now all matched values are wrapped in single quotes, effectively /
>> semantically casting them to strings.
>> The proposal is to remove the single quotes from this definition and
>> leave it to the tests to wrap values in quotes when string comparisons are
>> desired.
>> It would be great if the tests could convey the intent of the types in
>> use clearly and not rely too much on various ecmascript quirks related to
>> type-casting.
>> Here's the diff: https://github.com/zjnue/hscxml/commit/
>> f964dcbbe72d54cc588d2fe3fd1bb4a3320e81c6
>>
>> Best regards,
>> Zjnue
>>
>> PS: The XPath XSL change has not been tested yet.
>>
>>
> --
> Jim Barnett
> Genesys
>
>