Re: [webmin-devel] making config change to existing module, addingpopup"select users" list

Jamie Cameron wrote:
>>   return
>>       $preta .
>>       $config{'ignore_users'} .
>>       $postta .
>>       ' ' .
>>       &user_chooser_button("ignore_users", 1);
> I have one suggestion here - change the $config{'ignore_users'} to $_[0]

   OK.  I did so, and it works now. (= When I originally implemented
the function, I had it displaying all values to @_ to see if anything
was passed in, but since I didn't have a value yet, nothing was shown,
and I mistakenly assumed that nothing was passed in.  Slap my hand!
(=

   Anyway, it works now, and splendidly I must say.  AFAIK, these changes
satisfy your given requirements of "well written, don't break anything,
and optional".

   The only thing that I _don't_ have, however, is multi-language
config.info files. (=

   Is there anything else that you suggest I do/check/examine/etc
before I pass the patches and stuff on to you?

   Thanks!

Mr Duck



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
-
Forwarded by the Webmin development list at [email protected]
To remove yourself from this list, go to
http://lists.sourceforge.net/lists/listinfo/webadmin-devel