Re: [webmin-devel] Webmin 1.480 and StressFree theme compatibility

Thanks Jamie,
Yes I updated the theme late last night (probably right before you  
tested it).

In the earlier releases I was using the theme_postbody function to add  
HTML after the content.
I'm not sure what was going wrong, but renaming the function to  
theme_footer (and adding HTML closing tags) fixed the problem.

I've asked a couple of other people to test it, but I am pretty sure  
things are back to normal now.

Cheers,


David



On 6/09/2009, at 9:41 AM, Jamie Cameron wrote:

> On 04/Sep/2009 04:58 David Harrison wrote ..
>>
>> Hi,
>> With the current release of Webmin the theme I maintain  
>> (StressFree) does not render correctly on non-category pages.
>> i.e. When a user browses to an actual module.
>>
>> Looking at the HTML the post body and footer is not output by  
>> Webmin on these pages.
>> Instead the output returned from Webmin stops at the end of the  
>> body content.
>>
>> e.g.
>>
>> -- Normal HTML before this---
>> </td>
>> </tr>
>> </table></td></tr></table>
>> <table class='ui_form_end_buttons'
>>   ><tr>
>> <td><input class='ui_submit' type=submit value="Search">
>> </td>
>> </tr></table>
>> </form>
>> <hr id='pre_footer_hr'>
>> <br>
>> -- Output ends here --
>>
>> What has changed in Webmin recently that would be causing this  
>> behavior?
>> (And why isn't this change a ffecting the category pages as well as  
>> the modules themselves?)
>>
>> I believe everything worked fine in Webmin 1.470.
>>
>> There is nothing in the Webmin logs that indicates there is a  
>> problem and I have tried deleting all aspects of the theme but the  
>> problem persists.
> Hi David,
>
> I don't see this when using your latest theme (version 2.01) with  
> the latest development version of Webmin. You might want to try that  
> out first .. it is version 1.488, and is available from http://www.webmin.com/devel.html 
>   .
>
> For example, if I go to http://myserver:10000/exports/index.cgi , I  
> can see the whole page OK, including the stressfree@ email address  
> at the end.
>
>  - Jamie
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008  
> 30-Day
> trial. Simplify your report design, integration and deployment - and  
> focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july-
> Forwarded by the Webmin development list at [email protected]
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

-
Forwarded by the Webmin development list at [email protected]
To remove yourself from this list, go to
http://lists.sourceforge.net/lists/listinfo/webadmin-devel