[webmin-devel] Patches for webmin squid module

Hello,
I am new to webmin and i have come to absolutely love it.
While testing it out i found two issues as described below.

1. since version 2.6 squid configuration options redirect_path and
redirect_children have been renamed to url_rewrite_path and
url_rewrite_children respectively. Attached patch
squid_2_6_url_rewrite.patch makes this addition.

2. while backing up the squid configuration, acls that have the -i
option specified to ignore the case will not get backed up.
For example:
acl aclname url_regex "/etc/squid/urls.acl" will get backed up, but
acl aclname url_regex -i "/etc/squid/urls.acl" will not get backed up.

I figured that the issue is because of the -i option, and the backup
script only looks for the third argument. Attached patch
squid_backup_configuration.patch fixes this issue.

P.S.
 - These patches are generated against the current git head.
 - I have no perl programming experience and the patches provided
herewith are only taken from similar code present in webmin. Having
said that i request you to review the patches before accepting them.

Thanks and Regards
~Sameer

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing
http://p.sf.net/sfu/novell-sfdev2dev
-
Forwarded by the Webmin development list at [email protected]
To remove yourself from this list, go to
http://lists.sourceforge.net/lists/listinfo/webadmin-devel