Re: [webmin-devel] Question about feature request.
Pavlov Dmitry <[email protected]> Sat, 01 Oct 2011 00:20:30 +0400
| Newsgroups | gmane.comp.web.webmin.devel |
|---|---|
| Message-ID | <1317414030.2400.5.camel@Diamond> |
--===============8591312943747187290==
Content-Type: multipart/alternative; boundary="=-0TfDe0FE/ucR6aeQxipp"
--=-0TfDe0FE/ucR6aeQxipp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Thank you, for applying patches.
BTW, I found 2 lines that i forgot to remove from code in
0001-batch-support-for-password-change-at-next-login-for-.patch
&webmin_debug_log('ldap-batch',"going to set shadow last change");
&webmin_debug_log('ldap-batch',"finished to set change");
they were used for some debug output and can be freely removed before
commiting changes to repo, sorry for that code.
В Пт., 30/09/2011 в 13:14 -0700, Jamie Cameron пишет:
> On 30/Sep/2011 12:49 Dmitry Pavlov <[email protected]> wrote ..
>
> > Hello.
> > I added a feature request for adding support for force password
> > change at next login feature in ldap-useradmin with patches attached
> > to the ticket:
> > https://sourceforge.net/tracker/?func=detail&aid=3415467&group_id=17457&atid=367457
> >
> > I'd like to know if inclusion of that feature is possible in webmin
> > as it is now or maybe I need to correct patches somehow?
> >
> > --
> > Dmitry Pavlov
> >
>
> Thanks for the notification - I didn't see that ticket. I have applied
> your patches though, and will include them in the next release.
>
> BTW, an even better way to submit patches is via github. You can
> create a branch of Webmin, then submit a change which I can integrate
> into the main branch with a single click at github.com ..
>
> - Jamie
>
>
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2dcopy2
> - Forwarded by the Webmin development list at [email protected] To remove yourself from this list, go to http://lists.sourceforge.net/lists/listinfo/webadmin-devel
--
Pavlov Dmitry
--=-0TfDe0FE/ucR6aeQxipp
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.32.2">
</HEAD>
<BODY>
Thank you, for applying patches.<BR>
BTW, I found 2 lines that i forgot to remove from code in 0001-batch-support-for-password-change-at-next-login-for-.patch<BR>
<BR>
&webmin_debug_log('ldap-batch',"going to set shadow last change");<BR>
&webmin_debug_log('ldap-batch',"finished to set change");<BR>
<BR>
they were used for some debug output and can be freely removed before commiting changes to repo, sorry for that code.<BR>
<BR>
В Пт., 30/09/2011 в 13:14 -0700, Jamie Cameron пишет:<BR>
<BLOCKQUOTE TYPE=CITE>
On 30/Sep/2011 12:49 Dmitry Pavlov <[email protected]> wrote .. <BR>
<BLOCKQUOTE TYPE=CITE>
Hello.<BR>
I added a feature request for adding support for force password change at next login feature in ldap-useradmin with patches attached to the ticket:<BR>
<A HREF="https://sourceforge.net/tracker/?func=detail&aid=3415467&group_id=17457&atid=367457">https://sourceforge.net/tracker/?func=detail&aid=3415467&group_id=17457&atid=367457</A><BR>
<BR>
I'd like to know if inclusion of that feature is possible in webmin as it is now or maybe I need to correct patches somehow?<BR>
<BR>
-- <BR>
Dmitry Pavlov<BR>
<BR>
</BLOCKQUOTE>
Thanks for the notification - I didn't see that ticket. I have applied your patches though, and will include them in the next release.<BR>
<BR>
BTW, an even better way to submit patches is via github. You can create a branch of Webmin, then submit a change which I can integrate into the main branch with a single click at github.com ..<BR>
<BR>
- Jamie<BR>
<BR>
<PRE>
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
<A HREF="http://p.sf.net/sfu/splunk-d2dcopy2">http://p.sf.net/sfu/splunk-d2dcopy2</A>
- Forwarded by the Webmin development list at <A HREF="mailto:[email protected]">[email protected]</A> To remove yourself from this list, go to <A HREF="http://lists.sourceforge.net/lists/listinfo/webadmin-devel">http://lists.sourceforge.net/lists/listinfo/webadmin-devel</A>
</PRE>
</BLOCKQUOTE>
<BR>
<TABLE CELLSPACING="0" CELLPADDING="0" WIDTH="100%">
<TR>
<TD>
<PRE>
--
Pavlov Dmitry
</PRE>
</TD>
</TR>
</TABLE>
</BODY>
</HTML>
--=-0TfDe0FE/ucR6aeQxipp--
--===============8591312943747187290==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2dcopy2
--===============8591312943747187290==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
-
Forwarded by the Webmin development list at [email protected]
To remove yourself from this list, go to
http://lists.sourceforge.net/lists/listinfo/webadmin-devel
--===============8591312943747187290==--