Re: Github Fork And Contibutions via Pull Request

Michael Hast <[email protected]>
Newsgroups gmane.comp.web.webobjects.wonder-disc
Message-ID <[email protected]>
Thanks Maik:

Just to clarify: Here is what normally do. After creating the fork and 
doing a clone, I have the master branch checked out. Now we come across 
a bug or need to do a feature enhancement.

1. Code the change, commit the change and push it to our fork on github 
(master branch).
2. Tag master branch and push that tag to our fork, and use that tag for 
our production builds.

Now I want to make that enhancement available via Pull Request to the 
community. Now I checkout integration branch and create a branch of it 
and commit my change to that branch, push it to my fork and create a 
pull request?

Michael

On 10/18/2012 9:50 AM, Maik Musall wrote:
> Hi Michael,
>
> put everything that belongs together in a new branch that bases on the current integration branch. Each branch can contain several commits, and you can even submit more commits to that branch until the pull request is accepted). You then push that branch to your github fork and create a pull request on that branch against projectwonder/integration on github.
>
> Maik
>
> Am 18.10.2012 um 18:15 schrieb Michael Hast <[email protected]>:
>
>> Hello everyone:
>>
>> I am not sure how to wrap my brain around this, so I ask. My company has
>> finally created a fork of Wonder on github. We have a few changes to the
>> Ajax and ERChangeNotificationJMS frameworks. The Ajax framework changes
>> are to 3 components. And the change to ERChangeNotificationJMS was to
>> make it work with OpenJMS (authentication and topic had to be added to
>> the code to make it work).
>>
>> Is there now one pull request per fork or per commit? How does
>> contributing from our fork work now?
>>
>> Michael
>> --
>> Tel: (602) 279-4600 ext: 635
>> Desert Sky Software: www.desertsky.com
>>      Specializing in the Development and Hosting of
>>      e-Business Applications.
>>
>> ------------------------------------------------------------------------------
>> Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics
>> Download AppDynamics Lite for free today:
>> http://p.sf.net/sfu/appdyn_sfd2d_oct
>> _______________________________________________
>> Wonder-disc mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/wonder-disc
>

-- 
Tel: (602) 279-4600 ext: 635
Desert Sky Software: www.desertsky.com
     Specializing in the Development and Hosting of
     e-Business Applications.

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.