[OS-JIRA] Created: (WOL-1219) use constants in generated migration for better readability

"Johann Werner (JIRA)" <[email protected]> Mon, 21 Nov 2011 16:43:51 +0000 (UTC)

Newsgroups	gmane.comp.web.webobjects.woproject.devel
Message-ID	<695127066.372.1321893831099.JavaMail.tomcat@us-rs01.objectstyle.com>

use constants in generated migration for better readability
-----------------------------------------------------------

                 Key: WOL-1219
                 URL: http://issues.objectstyle.org/jira/browse/WOL-1219
             Project: WOProject/WOLips
          Issue Type: Improvement
         Environment: WOLips 3.7.10096
            Reporter: Johann Werner
            Priority: Trivial


The generated migration code from Entity Modeler uses the plain boolean values true and false as parameter in the different column creation methods to determine if the attribute is optional or not:

myTable.newIntegerColumn("myIntAttribute", false);
myTable.newStringColumn("myStringAttribute", 50, true);

The superclass ERXMigrationDatabase.Migration defines two constants that would improve the readability of that code:

myTable.newIntegerColumn("myIntAttribute", NOT_NULL);
myTable.newStringColumn("myStringAttribute", 50, ALLOWS_NULL);

Entity Modeler should use those constants.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira