Re: VMS patch set (extensive) - first try (almost)
Hrvoje Niksic <[email protected]>
| Newsgroups | gmane.comp.web.wget.patches |
|---|---|
| Message-ID | <[email protected]> |
[email protected] (Steven M. Schweda) writes: > The fflush function flushes the HP C RTL buffers. However, RMS > has its own buffers. The fflush function does not guarantee > that the file will be written to disk. (See the description of > fsync for a way to flush buffers to disk.) That seems perfectly reasonable and is exactly what Wget expects. I wasn't joking about my reasons to introduce the flush, and I'm sorry that you find them ridiculous. Regardless of that, it was never my intention to slow down anyone's download, and therefore I find it perfectly acceptable that your VMS patches #ifdef it out. At the moment I see no reason to remove the fflush on systems supported by Wget mainline. For what it's worth, and removing the fflush doesn't make any difference in download speed on Linux. (Tested with fast downloads over the local network and from localhost.)