Re: New zlib patch (supports gzip encoding)

On Thu, 28 Apr 2005, Hrvoje Niksic wrote:
> Mark Atkinson <[email protected]> writes:
> Thanks for sharing this.  The problem is that it doesn't decompress
> the data transparently, which is really a must, both for performance
> and probably for handling of -c and restarted downloads.  I planned to
> add such support for 1.11.

yes, I note this fact in my comments.  Luckily files aren't scanned for 
anchors in-line, so -r still works with this patch.

>> According to the zlib documentation it supports large files (4G),
> Does it refer to files larger than 4G or to files in the 2G-4G range?

That should have been ( > 4G )

http://www.gzip.org/zlib/zlib_faq.html#faq32

>> It adds --compress, or -z options to command line to request
>> 'Accept-Encoding: gzip'.
>
> If we were to add such support, shouldn't that be the default?

It could be, so you would rather have --no-compress, similar to 
--no-keepalives?

> Note that you needn't add -R for Solaris; Wget is using libtool, which
> adds -R automatically.

Noted, I'll remove it.

>> +#ifdef HAVE_ZLIB
>> +# include "zlib.h"
>> +#endif
>
> Shouldn't this be <zlib.h>?

If you use --with-zlib=[DIR], you'd want this to be quote enclosed since 
it doesn't occur in the preprocessor/compilers built in search path.

Thanks for the comments!

--
Mark Atkinson
(!wired)?(coffee++):(wired);