Re: New zlib patch (supports gzip encoding)
Hrvoje Niksic <[email protected]> Fri, 29 Apr 2005 20:05:44 +0200
| Newsgroups | gmane.comp.web.wget.patches |
|---|---|
| Message-ID | <[email protected]> |
Mark Atkinson <[email protected]> writes: >>> It adds --compress, or -z options to command line to request >>> 'Accept-Encoding: gzip'. >> >> If we were to add such support, shouldn't that be the default? > > It could be, so you would rather have --no-compress, similar to > --no-keepalives? Exactly. Note that the OPT_BOOLEAN variable would stay exactly like it is, you would simply need to add `opt.compress=1' to init.c:defaults(). >> Note that you needn't add -R for Solaris; Wget is using libtool, which >> adds -R automatically. > > Noted, I'll remove it. Sorry about that; it's the other way around. You're supposed to *always* use -R, and libtool will see to it that it's translated to the appropriate linker magic for other OS-es, including removing it where RPATH-by-default is deemed inappropriate (Linux). See the OpenSSL detection for details. >> Shouldn't this be <zlib.h>? > > If you use --with-zlib=[DIR], you'd want this to be quote enclosed > since it doesn't occur in the preprocessor/compilers built in search > path. But #include <...> surely respects -I? How would #include <openssl/...> work otherwise?