Symbolic constants

Hrvoje Niksic <[email protected]> Thu, 01 Sep 2005 18:45:47 +0200
Newsgroups gmane.comp.web.wget.patches
Message-ID <[email protected]>
This changes "magic constants" in the code to symbolic constants, as
they should have been done in the first place.


2005-09-01  Hrvoje Niksic  <[email protected]>

	* progress.c: Introduce symbolic constants for "magic" values of
	0.2 and 0.9, REFRESH_INTERVAL and ETA_REFRESH_INTERVAL.

Index: src/progress.c
===================================================================
--- src/progress.c	(revision 2065)
+++ src/progress.c	(working copy)
@@ -483,6 +483,14 @@
    download speeds are scratched.  */
 #define STALL_START_TIME 5
 
+/* Time between screen refreshes will not be shorter than this, so
+   that Wget doesn't swamp the TTY with output.  */
+#define REFRESH_INTERVAL 0.2
+
+/* Don't refresh the ETA too often to avoid jerkiness in predictions.
+   This allows ETA to change approximately once per second.  */
+#define ETA_REFRESH_INTERVAL 0.99
+
 struct bar_progress {
   wgint initial_length;		/* how many bytes have been downloaded
 				   previously. */
@@ -616,7 +624,7 @@
       received_sigwinch = 0;
     }
 
-  if (dltime - bp->last_screen_update < 0.2 && !force_screen_update)
+  if (dltime - bp->last_screen_update < REFRESH_INTERVAL && !force_screen_update)
     /* Don't update more often than five times per second. */
     return;
 
@@ -913,7 +921,7 @@
 	     any value to the user. */
 	  if (bp->total_length != size
 	      && bp->last_eta_value != 0
-	      && dl_total_time - bp->last_eta_time < 0.9)
+	      && dl_total_time - bp->last_eta_time < ETA_REFRESH_INTERVAL)
 	    eta = bp->last_eta_value;
 	  else
 	    {