Re: PATCH - underlaid directory for system pages

Hello again,

On Wed, Feb 25, 2004 at 06:48:58PM +0100, Thomas Waldmann wrote:
> >!             if config.underlay_dir:
> >!                 from distutils.file_util import copy_file
> > !                 copy_file(page_filename,
> 
> Uuh. Is there no other way than to import from distutils? OK, we use it 
> for installing anyway, but I think this is the first time it is used in 
> core code.

I found that copy2() from shutil will do.

> >+             msg = _('You can not delete this page because it is treated 
> >as a base.'))
> 
> "As a base?" - maybe just tell that this page is from the underlay 
> directory.
> 
> >+         msg = _('You can not rename this page because it is treated as a 
> >base.')
> 
> Same.

Got it.

Please find a new patch, with comments from Thomas applied:

    http://toh.no-ip.com/TohToh/

Thank you very much.

-- 
Fujio Nobori                                     il|li
    email: [email protected]                   q|@.@|p
                                              m. ( o ) .m
                                             ~~~~~~~~~~~~~


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click