Re: Include.py in moin v1.1 vs v1.2 - feature request

digging in to the code I see that on line 172 of the v1.2 Include.py
is the difference that causes the behavior I'm seeing:

The < refers to v1.1
The > refers to v1.2
178,179c172,173
<         if args.group('htext'):
<             heading = args.group('htext') or inc_page.split_title()
---
>         if args.group('heading'):
>             heading = args.group('htext') or inc_page.split_title(macro.request)

So if htext wasn't defined in v1.1 the link and edit icon wouldn't be acted upon
before the included text.  In v1.2 this changed to heading, which is defined 
regardless.  A quick edit and my accustomed behavior was back.

But was it the right thing to do?  What other behavior am I breaking?


On Thu, Mar 18, 2004 at 12:14:24PM -0800, Michael Rasmussen wrote:
> Took the plunge and made the easy upgrade from 1.1 to 1.2 last night.
> 
> I note that on v1.2 the Include macro outputs page contents like this:
> 
>   Link to Page   Edit_Icon
>   Contents of the page after processing arguments
> 
> While in v1.1 it was:
> 
>   Contents of the page after processing arguments
>   Link to Page   Edit_Icon
> 
> Could this sorting be made into a parameter?  Alternatively, could I get
> a patch to the v1.2 version to restore the v1.1 behavior?
> 
> Michael 'wishes I knew Python better' R
> 
> -- 
>     Michael Rasmussen, Portland Oregon  
>   Be appropriate && Follow your curiosity
>  http://meme.patch.com/memes/BicycleRiding
>    Get Fixed:  http://www.dampfixie.org
>   The fortune cookie says:
> Men occasionally stumble over the truth, but most of them pick themselves
> up and hurry off as if nothing had happened.
> 		-- Winston Churchill
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> Moin-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/moin-devel

-- 
    Michael Rasmussen, Portland Oregon  
  Be appropriate && Follow your curiosity
 http://meme.patch.com/memes/BicycleRiding
   Get Fixed:  http://www.dampfixie.org
  The fortune cookie says:
compuberty, n:
	The uncomfortable period of emotional and hormonal changes a
	computer experiences when the operating system is upgraded and
	a sun4 is put online sharing files.



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click