[PATCH] Fix PageEditor puts message div inside content div

David Greaves <[email protected]> Mon, 30 Aug 2004 16:44:06 +0100
Newsgroups gmane.comp.web.wiki.moin.devel
Message-ID <[email protected]>
Can I ask for this change to PageEditor please.

I think there are a set of <div> elements that should always be top level.
This patch fixes an instance where 'message' is not at the top level.

There should be a DTD :)
I started something ages ago here:
http://moinmoin.wikiwikiweb.de/MoinMoinTodo_2fSkinPlugins_2fThemeCssSpecification

Without this patch, message <divs> behave differently in the editor page 
(where they are within
the content div) and other pages (where they are outside it).

Thanks

David


--- PageEditor.py.orig       2004-07-21 21:02:15.000000000 +0100
+++ PageEditor.py       2004-08-29 22:36:21.000000000 +0100
@@ -199,8 +199,6 @@
                     }) or ''
         )

-        self.request.write('<div id="content">\n') # start content div
-
         # get request parameters
         try:
             text_rows = int(form['rows'][0])
@@ -259,6 +257,8 @@
         if edit_lock_message or message:
             self.request.write('<div id="message">%s%s</div>' % 
(message, edit_lock_message))

+        self.request.write('<div id="content">\n') # start content div
+
         # get the text body for the editor field
         if form.has_key('template'):
             # "template" parameter contains the name of the template page



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click