[ moin-Patches-1035685 ] Fixes id sections for preview

"SourceForge.net" <[email protected]> Thu, 21 Oct 2004 16:28:46 -0700
Newsgroups gmane.comp.web.wiki.moin.devel
Message-ID <[email protected]>
Patches item #1035685, was opened at 2004-09-27 21:34
Message generated for change (Comment added) made by thomaswaldmann
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1035685&group_id=8482

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Nigel Metheringham (nigel)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fixes id sections for preview

Initial Comment:
Using default moin 1.2.3, when a preview of an edit is
done an additional <div id="content"> is emitted within
the preview div.
This means there are 2 content sections embedded within
one another, and tends to lead to real problems with
the CSS and layout particularly for themes which use a
left hand navigation bar.

This patch changes the div within the preview to have
id="previewcontent".

There is a chance it could interact badly with people
who have worked round the previous bug in their CSS,
but they should know enough to fix that.



----------------------------------------------------------------------

>Comment By: Thomas Waldmann (thomaswaldmann)
Date: 2004-10-22 01:28

Message:
Logged In: YES 
user_id=100649

fixed in
arch.thinkmo.de--2003-archives/moin--main--1.2--patch-362

will be in 1.2.4 when it is released


----------------------------------------------------------------------

Comment By: Nigel Metheringham (nigel)
Date: 2004-09-29 14:29

Message:
Logged In: YES 
user_id=31288

Although this is fixed in the 1.3 tree, the current 1.2
development tree does not have a fix.

I suggest that  OliverGraf's fix from 
 
http://moinmoin.wikiwikiweb.de/MoinMoinBugs_2fContentDivProblems

is applied to the 1.2 branch, or (probably better), the
attachment on that page:-

 
http://moinmoin.wikiwikiweb.de/MoinMoinBugs_2fContentDivProblems?action=AttachFile&do=get&target=preview-div.diff

----------------------------------------------------------------------

Comment By: Oliver Graf (lydon)
Date: 2004-09-28 07:55

Message:
Logged In: YES 
user_id=1011012

This is an old thing. Already fixed in 1.3.

See
http://moinmoin.wikiwikiweb.de/MoinMoinBugs_2fContentDivProblems


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1035685&group_id=8482


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl