Re: 1.3.2 does not run on IIS due to error in request.py

On Tue, 25 Jan 2005 12:40:01 +0100, Robert Seeger wrote:

> Sorry, I forgot to mention that I had fixed the request_uri issue as well.
> IIS does indeed not supply 'REQUEST_URI', so my workaround for an issue with
> this (I think I fixed this in 1.3.0 already and did not think about it) was
>         self.request_uri = env.get('REQUEST_URI', '%s'%self.script_name)
> (this is probably not quite correct, I just needed something useful in that
> variable for the request.url variable that is used to find a wiki in a farm
> config).
> Thus, the first check was always true in my case and the problem was
> self-made. Nevertheless I think that
>   server_software.find('Apache/1.3') == -1
> was meant to be
>   server_software.find('Apache/1.3') != -1
> if the first check was intended for apache only.

No, it was not. The first check should just run if a) there is an
request_uri (a valid one) and b) the server is not Apache 1.3.
I guess you screwed up request_uri (your code does not seem to assemble it
correctly) and glitched into this problem. I am not sure if I should have
expected such a broken request_uri :-)

Maybe you give us some reasons why MoinMoin needs that request_uri ...
Normally, it should not. Please try to run MoinMoin 1.3.3 with no local
modifications (at least not in that function :-)) and the following patch
applied: (see first link on that page)
	http://moinmoin.wikiwikiweb.de/KnownIssues

Kind regards,
Alexander



-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl