Re: FileFinder.php default path logic
"Marc-Etienne Vargenau \(Nokia\) via Phpwiki-talk" <[email protected]> Mon, 29 Jan 2024 18:45:29 +0000
| Newsgroups | gmane.comp.web.wiki.phpwiki.talk |
|---|---|
| Message-ID | <PR3PR07MB81838E4D1606A1DB0F59E57EAC7E2@PR3PR07MB8183.eurprd07.prod.outlook.com> |
--===============1320802575663741386== Content-Language: fr-FR Content-Type: multipart/alternative; boundary="_000_PR3PR07MB81838E4D1606A1DB0F59E57EAC7E2PR3PR07MB8183eurp_" --_000_PR3PR07MB81838E4D1606A1DB0F59E57EAC7E2PR3PR07MB8183eurp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi Christof, Thank you for the report. I have fixed the test, now testing against =93array()=94 instead of =93fals= e=94. Best regards, Marc-Etienne -- Marc-Etienne Vargenau [email protected]<mailto:marc-etienne.v= [email protected]> Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE Mobile: +33 6 24 49 78 68<tel:+33624497868> Senior Specialist Open Source Planned absence: none De : Christof Meerwald via Phpwiki-talk <[email protected]= > Date : dimanche, 21 janvier 2024 =E0 19:57 =C0 : [email protected] <[email protected]= t> Cc : Christof Meerwald <[email protected]> Objet : [Phpwiki-talk] FileFinder.php default path logic CAUTION: This is an external email. Please be very careful when clicking li= nks or opening attachments. See the URL nok.it/ext for additional informati= on. I don't think it makes sense to check if the member has already been set in the constructor. And having the default argument "array()", but then comparing against "false" means we never get into the then branch. Patch is attached (so we only use the _get_include_path if FileFinder has been called with no argument specified, which I think is the intention here). Christof -- https://cmeerw.org sip:cmeerw at cmeerw.org mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org --_000_PR3PR07MB81838E4D1606A1DB0F59E57EAC7E2PR3PR07MB8183eurp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable <html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:sc= hemas-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/of= fice/2004/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DWindows-1= 252"> <meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)"> <style><!-- /* Font Definitions */ @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:Aptos; panose-1:2 11 0 4 2 2 2 2 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; font-size:10.0pt; font-family:"Calibri",sans-serif;} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} span.EmailStyle19 {mso-style-type:personal-reply; font-family:"Calibri",sans-serif; color:windowtext;} .MsoChpDefault {mso-style-type:export-only; font-size:10.0pt; mso-ligatures:none;} @page WordSection1 {size:612.0pt 792.0pt; margin:70.85pt 70.85pt 70.85pt 70.85pt;} div.WordSection1 {page:WordSection1;} --></style> </head> <body lang=3D"FR" link=3D"blue" vlink=3D"purple" style=3D"word-wrap:break-w= ord"> <div class=3D"WordSection1"> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;mso-fareast-language= :EN-US">Hi Christof,<o:p></o:p></span></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt;mso-fareast-language= :EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US">Thank you for the report.<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US">I have fixed the test, now testing against =93array(= )=94 instead of =93false=94.<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US">Best regards,<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US">Marc-Etienne<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US"><o:p> </o:p></span></p> <div> <div> <p class=3D"MsoNormal"><span style=3D"font-family:"Courier New";c= olor:#212121">-- <br> Marc-Etienne Vargenau <a href=3D"mailto:marc-etienne.vargenau@nok= ia.com" title=3D"mailto:[email protected]"><span style=3D"col= or:#0078D7;text-decoration:none">marc-etienne</span><span style=3D"color:#0= 078D7">[email protected]</span></a><br> Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE<br> Mobile: <a href=3D"tel:+33624497868"><span style=3D"color:#0078D7">+33= 6 24 49 78 68</span></a></span><span style=3D"font-size:11.0pt;color:#2121= 21"><o:p></o:p></span></p> </div> </div> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"Cour= ier New";color:#212121">Senior Specialist Open Source<br> Planned absence: </span><b><span lang=3D"EN-US" style=3D"font-size:11.= 0pt;font-family:"Courier New";color:#212121">none</span></b><span= lang=3D"EN-US" style=3D"font-size:11.0pt;color:#212121"><o:p></o:p></span>= </p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-size:11.0pt;mso-f= areast-language:EN-US"><o:p> </o:p></span></p> <div id=3D"mail-editor-reference-message-container"> <div> <div style=3D"border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm = 0cm 0cm"> <p class=3D"MsoNormal" style=3D"margin-bottom:12.0pt"><b><span style=3D"fon= t-size:12.0pt;font-family:"Aptos",sans-serif;color:black">De = ;: </span></b><span style=3D"font-size:12.0pt;font-family:"Aptos",sa= ns-serif;color:black">Christof Meerwald via Phpwiki-talk <phpwiki-talk@l= ists.sourceforge.net><br> <b>Date : </b>dimanche, 21 janvier 2024 =E0 19:57<br> <b>=C0 : </b>[email protected] <phpwiki-talk@lists= .sourceforge.net><br> <b>Cc : </b>Christof Meerwald <[email protected]><br> <b>Objet : </b>[Phpwiki-talk] FileFinder.php default path logic<o:p></= o:p></span></p> </div> <div> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt"><br> CAUTION: This is an external email. Please be very careful when clicking li= nks or opening attachments. See the URL nok.it/ext for additional informati= on.<br> <br> <br> <br> I don't think it makes sense to check if the member has already been<br> set in the constructor. And having the default argument "array()"= , but<br> then comparing against "false" means we never get into the then<b= r> branch. Patch is attached (so we only use the _get_include_path if<br> FileFinder has been called with no argument specified, which I think<br> is the intention here).<br> <br> <br> Christof<br> <br> --<br> <br> <a href=3D"https://cmeerw.org">https://cmeerw.org</a> &nbs= p; &= nbsp; sip= :cmeerw at cmeerw.org<br> <a href=3D"mailto:cmeerw">mailto:cmeerw</a> at cmeerw.org = &nb= sp; xmpp:cmeerw at cmeerw.org<o:p></o:p></span></p> </div> </div> </div> </div> </body> </html> --_000_PR3PR07MB81838E4D1606A1DB0F59E57EAC7E2PR3PR07MB8183eurp_-- --===============1320802575663741386== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============1320802575663741386== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Phpwiki-talk mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/phpwiki-talk --===============1320802575663741386==--