Re: PmSyntax and editing buttons

I had pmwiki 2.3.16 installed. I upgraded to 2.3.23 to see if that would help. It didn't, now GUI-buttons are not visible.

But I noticed that I had replaced guiedit.js and guiedit.php before, probably when upgrading to 2.3.16.
I guess I was replacing them with older versions.

Right now the 2.3.23 versions are in place, and no GUI-buttons.

-Johan Bengtsson

________________________________________
From: Petko Yotov <[email protected]>
Sent: Monday, May 15, 2023 10:36
To: Johan Bengtsson
Cc: PmWiki Users
Subject: Re: [pmwiki-users] PmSyntax and editing buttons

Are all core files updated?

Especially scripts/guiedit.php and pub/guiedit/*.js ?

Petko

--
If you upgrade :  https://www.pmwiki.org/Upgrades

On 15/05/2023 10:26, Johan Bengtsson wrote:
> It is just standard buttons, no custom stuff. It works like it should
> for me in the pmwiki.org sandbox.
>
> I tried disabling a lot of the recipes for the wiki, but that did not
> help.
>
> -Johan Bengtsson
>
> ________________________________________
> From: Petko Yotov <[email protected]>
> Sent: Friday, May 12, 2023 16:50
> To: Johan Bengtsson
> Cc: PmWiki Users
> Subject: Re: [pmwiki-users] PmSyntax and editing buttons
>
> If you are using the standard $GUIButtons as shown in the
> documentation,
> or calling the core functions to insert text, that is insertText(),
> then
> it "should" work. Try it on the WikiSandbox:
>
>    https://www.pmwiki.org/wiki/Main/WikiSandbox?action=edit
>
> If it doesn't work for some reason, it may be a bug or an omission and
> I'd be interested in tracking it and fixing it.
>
> Now, if you have custom functions that insert code by directly
> manipulating the text.value property, after doing that you also need to
> trigger one "input" event:
>
>    var evt = new Event('input');
>    document.getElementById('text').dispatchEvent(evt);
>
> Unlike other DOM elements, changes in textarea value cannot be detected
> by a MutationObserver. The only other option I know and even used at
> some point, is to check the value every 50-100 milliseconds. This uses
> up a lot of CPU and battery, so I removed it.
>
> Petko
>
>
> On 12/05/2023 15:54, Johan Bengtsson wrote:
>> I noticed this when having syntax highlighting enabled for the edit
>> area: When inserting code via the edit buttons, I must press return
>> for the code to be visible.
>>
>> This is surely a bug?
>
> _______________________________________________
> pmwiki-users mailing list
> [email protected]
> http://www.pmichaud.com/mailman/listinfo/pmwiki-users