Checkins for 2.7 and 2.8 and missing unit tests
Florent Guillaume <[email protected]>
| Newsgroups | gmane.comp.web.zope.coders |
|---|---|
| Message-ID | <[email protected]> |
Hi coders, I must say I'm disappointed with a number of checkins that happened in the past month for the 2.7 and trunk of Zope 2: many are missing unit tests. While I understand the need to "fix bugs", I can't see the point of doing this without adding unit tests that exercise the problem, and document the why and how of things. Just because a patch sits in the collector and "works" is no reason to apply it without writing a test, especially for subtle features such as quoting and escaping. Here's a sample of things for which I believe unit tests are important: http://mail.zope.org/pipermail/zope-checkins/2004-November/028556.html no test of webdav escaping http://mail.zope.org/pipermail/zope-checkins/2004-November/028562.html no test (escaping, cdata) http://mail.zope.org/pipermail/zope-checkins/2004-November/028654.html no test (local roles) http://mail.zope.org/pipermail/zope-checkins/2004-December/028737.html no test (clone in webdav) http://mail.zope.org/pipermail/zope-checkins/2004-December/028750.html no test of ACTUAL_URL and URL quoting I would like to urge all committers to always write unit tests for every change they make. Florent -- Florent Guillaume, Nuxeo (Paris, France) CTO, Director of R&D +33 1 40 33 71 59 http://nuxeo.com [email protected]