[ZCM] [ZC] 2319/ 5 Comment "MailHost sends duplicate emails on zodb conflicts"

"Collector: Zope Bugs, Features, and Patches ..." <[email protected]> Wed, 02 May 2007 00:49:18 -0400
Newsgroups gmane.comp.web.zope.devel.collector-monitor
Message-ID <[email protected]>
Issue #2319 Update (Comment) "MailHost sends duplicate emails on zodb conflicts"
 Status Pending, Zope/bug medium
To followup, visit:
  http://www.zope.org/Collectors/Zope/2319

==============================================================
= Comment - Entry #5 by jens on May 2, 2007 12:49 am

It does not make MaildropHost obsolete at all. You're overlooking the asynchronous mail delivery, which is its main purpose. The transaction awareness was just a secondary feature.

________________________________________
= Comment - Entry #4 by ajung on May 2, 2007 12:35 am

+1 for accepting such a patch for Zope 2.11 since it makes
MailDropHost obsolete for most users (sorry Jens :-)) sending out a number of mails from time to time.
________________________________________
= Comment - Entry #3 by ajung on May 2, 2007 12:35 am

+1 for accepting such a patch for Zope 2.11 since it makes
MailDropHost obsolete for most users (sorry Jens :-)) sending out a number of mails from time to time.
________________________________________
= Comment - Entry #2 by tseaver on May 2, 2007 12:27 am

Thanks for the patch.  A couple of issues:

  - The whitespace in the patch is messed up -- please normalize,
    removing any tab characters.

  - This kind of change really needs unit tests;  can you
    please supply some? 

________________________________________
= Request - Entry #1 by marc_mengel on May 1, 2007 7:53 pm


Uploaded:  "mail.patch"
 - http://www.zope.org/Collectors/Zope/2319/mail.patch/view
If you have a script or action that sends email and does other work, that gets a ZODB conflict error, the mail gets sent a second (or third!) time as the conflict resolution runs again.  We noticed this in particular with AlphaFlow where several workflow items were occurring in a row, but it can happen any time you have a script that sends email and updates a ZODB object.

A resource manager for sending email solves this problem.

==============================================================