Re: [PATCH] subunit output for zope.testing

Hi Jonathan,

On Thu, Mar 11, 2010 at 5:52 PM, Jonathan Lange <[email protected]> wrote:
> Hello,
>
> For a long time, I've wanted to have a subunit output formatter for
> zope.testing. Subunit is a language-generic streaming protocol for
> test results. Once a test runner can display subunit output, it
> becomes much easier to write tools to process output programmatically.
> We want to use it in the Launchpad project for analyzing test results
> and for distributing our test runs across multiple machines. Other
> projects use it to get Hudson integration, or to glue their
> multi-language test suite into one result. More information on subunit
> can be found at http://launchpad.net/subunit.
>
> I've written a patch that adds subunit support to zope.testing by
> adding a new formatter object. The patch comes complete with tests and
> a willingness to jump through whatever legal hoops might be required
> to get it to land. The patch is attached, and can also be found as a
> merge proposal on Launchpad at
> https://code.edge.launchpad.net/~jml/zope.testing/subunit-output-formatter/+merge/19825
>
> I look forward to your replies.

The patch looks great to me, specially the testing coverage and the
fact it is completely optional to use subunit. Big +1 from me.

@Marius: re: run() vs run_internal(), the former would cause a
sys.exit() at some point, so run_internal() was added. I didn't spot
this change, but it looks fine to me.

I volunteer for commiting this patch and making a new major release,
if no one else volunteers.

-- Sidnei
_______________________________________________
Zope-Dev maillist  -  [email protected]
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )