Re: zope.test.doctest made into monkey-patches
Wolfgang Schnerring <[email protected]>
| Newsgroups | gmane.comp.web.zope.devel |
|---|---|
| Message-ID | <[email protected]> |
* Jim Fulton <[email protected]> [2010-04-20 20:35]: > On Tue, Apr 20, 2010 at 4:46 AM, Lennart Regebro <[email protected]> wrote: >> And here is another interesting experiment: >> svn+ssh://[email protected]/repos/main/zope.testing/branches/regebro-doctest-patching >> It replaces the custom doctest.py with monkey-patches. >> >> Benefits: We don't have to maintain a separate doctest.py, and we get >> the bugfixes from Python. > > Strong -1. > > Monkey patching should be used as a last resort. Monkey > patching the standard library is likely to make us look like > jack asses. That might be so. I don't share that position, but I have a different point that I want to make: Regardless of whether monkey-patching the stdlib is or isn't a Bad Thing(tm), I think Lennart's approach is an *improvement* over the previous situation where we copied a file from the stdlib wholesale[1] -- in my opinion that's definitely worse than a monkey-patch. Wolfgang [1] I know, I know, it was actually the other way around. But still. _______________________________________________ Zope-Dev maillist - [email protected] https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )