Re: encoding ignored for PageTemplate file uploads

On Sat, Oct 02, 2010 at 04:03:08PM +0200, Andreas Jung wrote:
> Chris Withers wrote:
> > Hi All,
> > 
> > Unless I'm missing something, the encoding text field that forms part of 
> > the file upload form on page template instances is completely ignored 
> > since it's not used in the pt_upload method of ZopePageTemplate instances.
> > 
> > Am I missing anything?
> 
> No - this parameter is ignored.
> 
> The code in pt_edit assumes for text/html-ish content that the encoding
> is either iso-8859-15 as default or provided by the HTML content through
> the html-equiv mechanism.
> 
> Either we treat the encoding field in the upload form as culprit
> and remove it or it could be used as dedicated encoding for text/html
> templates not providing an encoding specification themselves.

Not all page templates contain complete HTML pages; some are just
snippets and won't have a <meta http-equiv...>

I hope that's an argument for for making the encoding field work.

Marius Gedminas
-- 
http://pov.lt/ -- Zope 3/BlueBream consulting and development

_______________________________________________
Zope-Dev maillist  -  [email protected]
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkypC3QACgkQkVdEXeem149WHACff3MLk/pUZN7FB0EZi13D9XWu
1ocAnjg+f53/88CZrm/sb/+fGzxnIHst
=SQqm
-----END PGP SIGNATURE-----