Re: zope.testbrowser and WebTest (round 2)

On Sat, Feb 12, 2011 at 02:59:50PM +0100, Wolfgang Schnerring wrote:
> Hi,
> 
> sorry I'm replying this late. I've been busy, then sick, then busy
> again, so I'm afraid this has got pushed low on my stack of stuff...

No worries, I'm not in a big rush :)

> * Brian Sutherland <[email protected]> [2011-02-02 11:15]:
> > On Tue, Feb 01, 2011 at 09:32:11AM +0100, Wolfgang Schnerring wrote:
> >> * Brian Sutherland <[email protected]> [2011-01-31 09:54]:
> >> I'd prefer if we treated this as two separate steps, then:
> >> a) improve the testbrwoser+wsgi story by replacing wsgi_intercept with WebTest

I pulled this out of my original branch and put it here:

    svn+ssh://svn.zope.org/repos/main/zope.testbrowser/jinty-webtest3-minimal

The test coverage on this branch leaves much to be desired.

> >> b) extract the testbrowser part that talks to the Publisher

This is here and by necessity includes the changes for step (a):
    
    svn+ssh://svn.zope.org/repos/main/zope.testbrowser/jinty-webtest3
    svn+ssh://svn.zope.org/repos/main/zope.app.testing/branches/jinty-testbrowser

I would much prefer to merge both steps together.

> > Initially I did them together because it was the only way to get very
> > good test coverage of the WebTest integration. If we do it this way,
> > between steps a and b we'll have poor coverate. But that's not so bad as
> > the code has already been well tested on my current branch.
> >  
> >> As to (a), I'll still need to look at your code, but as I said I'm
> >> all in favour of using WebTest instead of wsgi_intercept.
> >
> > I'll try make a branch for this in the next week or so for you to review.
> 
> Thanks very much, I'll look throught it as soon as I find some time,
> probably not next week (I'm travelling), but hopefully the week after
> that, at the latest.

Sure, I can wait a few weeks. But let me know if you're not going to get
around to it.

> >> As to (b), I saw you moved the code to zope.app.testing. I have a
> >> few ideas in that area which I'll contact you off-list about.
> > Sure!
> 
> As we've discussed off-list, we now both feel that moving the
> publisher-testbrowser to zope.app.testing is a good idea, since the only
> applications that will want to use that testbrowser are those that use
> zope.app.testing -- the more modern approach of testing publisher-based
> applications is to use the code from zope.app.wsgi to create a WSGI
> application and then use the WSGI-enabled testbrowser to talk to that.

Great, looks like we have a consensus :)

-- 
Brian Sutherland
_______________________________________________
Zope-Dev maillist  -  [email protected]
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )