Re: Acquisition wrapped objects do not behave well on unicode call
David Glick <[email protected]>
| Newsgroups | gmane.comp.web.zope.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2/20/11 1:32 AM, Christian Zagrodnick wrote: > On 2011-02-19 17:17:44 +0100, Hanno Schlichting said: > >> On Thu, Feb 17, 2011 at 8:27 AM, Christian Zagrodnick<[email protected]> wrote: >>> On 2011-02-16 22:22:53 +0100, Hanno Schlichting said: >>>>> svn+ssh://svn.zope.org/repos/main/Acquisition/branches/zagy-unicode-should-be-called > Sure. >>>> I'll review, merge and release. Should be sometime this week, >>>> cannot promise a day. >> Branch reviewed, merged and released in Acquisition 2.13.6. >> >> Could you remove the merged branch once you updated your buildout config? > Done. > > Thanks for releasing! This change introduces a regression when calling unicode on wrapped objects that implement __str__ but not __unicode__. Essentially it is now doing the equivalent of str(aq_base(obj)) ... __str__ used to get a wrapped object as 'self', but now it is unwrapped. Here's a failing test that can be added to Acquisition's TestUnicode test case to demonstrate the issue: def test_str_fallback_is_still_wrapped(self): class A(Acquisition.Implicit): def __str__(self): return str(len(Acquisition.aq_chain(self))) wrapped = A().__of__(A()) self.assertEqual(u'2', unicode(wrapped)) This is currently causing some regressions in Plone tests. David ---------- David Glick Web Developer [email protected] 206.286.1235x32 Groundwire: You Are Connected http://groundwire.org Online tools and strategies for the environmental movement. Sign up for Groundwire News! http://groundwire.org/email-capture _______________________________________________ Zope-Dev maillist - [email protected] https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )