Re: cache_detail crash

Albertas Agejevas wrote on 22.09.2011 13:05:
> On Thu, Sep 22, 2011 at 12:59:43PM +0400, Ruslan Mahmatkhanov wrote:
>> Ok, this change works for me.
>>
>> It should be applied against src/App/CacheManager.py.
>> Would you mind to commit it?
>
>>               REQUEST.RESPONSE.setHeader('Content-Type', 'text/plain')
>> -            return '\n'.join('%6d %s'%(count, name) for count, name in detail)
>> +            return '\n'.join('%s %6d'%(count, name) for count, name in detail)
>
> This doesn't look right!  So count is %s, and name is %d?  Perhaps
> their order in detail changed?
>
> Albertas

detail is looks like that:

[('AccessControl.users.User', 3),
  ('App.ApplicationManager.ApplicationManager', 3),
..... ]

So if the count still should go first, this patch should work.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.

_______________________________________________
Zope-Dev maillist  -  [email protected]
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )

--- CacheManager.py.orig	2011-09-22 12:52:48.000000000 +0400
+++ CacheManager.py	2011-09-22 13:09:20.000000000 +0400
@@ -102,7 +102,7 @@
         if REQUEST is not None:
             # format as text
             REQUEST.RESPONSE.setHeader('Content-Type', 'text/plain')
-            return '\n'.join('%6d %s'%(count, name) for count, name in detail)
+            return '\n'.join('%6d %s'%(count, name) for name, count in detail)
         else:
             # raw
             return detail