Re: zope-tests - FAILED: 13, OK: 40

Tres Seaver <[email protected]>
Newsgroups gmane.comp.web.zope.devel
Message-ID <[email protected]>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/31/2011 11:48 AM, Christophe Combelles wrote:
> Le 31/10/2011 15:31, Tres Seaver a écrit : On 10/31/2011 04:43 AM,
> Wichert Akkerman wrote:
>>>> On 10/31/2011 07:21 AM, Tres Seaver wrote:
>>>>> These are all failures in the following zopeapp test::
>>>>> 
>>>>> - --------
>>>>> zope/app/applicationcontrol/tests/test_zope_version.py 
>>>>> -------- def test_WrongLocale(self): """Demonstrate bug 
>>>>> 177733""" currentPath = 
>>>>> os.path.dirname(os.path.abspath(__file__)) if
>>>>> isSVNAvailable() and isSVNCheckout(currentPath): zv =
>>>>> ZopeVersion(currentPath) zv.getZopeVersion() # check that
>>>>> we don't get a 'Development/Unknown' version 
>>>>> self.assert_(zv.result.startswith('Development/Revision:
>>>>> ')) - 
>>>>> --------------------------------------------------------------------------
>>>>>
>>>>>
>>>>>
>
>>>>> 
I have no theory for how that test could suddenly start failing (nor
>>>>> even what it is really supposed to test).  It doesn't fail
>>>>> on my machine on any version of Python.
>>>> 
>>>> Different version of subversion installed perhaps?
> 
> 
> Hmmm, that would seem odd.  Christophe, has that machine recently 
> updated its subversion (between the test runs reported Saturday
> night and those reported last night)?
> 
>> I've launched the test with a pdb in zopeversion.py, and it looks
>> like a locale problem.
> 
>> (Pdb) !print self._getSVNInfoOutput().read() Chemin?\194?\160: 
>> /home/ccomb/ztk1.1dev-slave/Python2.7.2-Linux-64bit/build/src/zope.app.applicationcontrol/src/zope/app/applicationcontrol/tests
>>
>> 
URL?\194?\160:
>> svn://svn.zope.org/repos/main/zope.app.applicationcontrol/trunk/src/zope/app/applicationcontrol/tests
>>
>> 
Racine du d?\195?\169p?\195?\180t?\194?\160: svn://svn.zope.org/repos/main
>> UUID du d?\195?\169p?\195?\180t?\194?\160:
>> 62d5b8a3-27da-0310-9561-8e5933582275 R?\195?\169vision?\194?\160:
>> 123191 Type de n?\197?\147ud?\194?\160: r?\195?\169pertoire 
>> T?\195?\162che programm?\195?\169e?\194?\160: normale Auteur de
>> la derni?\195?\168re modification?\194?\160: menesis 
>> R?\195?\169vision de la derni?\195?\168re modification?\194?\160:
>> 121717 Date de la derni?\195?\168re modification: 2011-05-18
>> 21:23:30 +0200 (Wed 18 May 2011)
> 
>> Then :
> 
>> (Pdb) print info {'UUID du
>> d?\\195?\\169p?\\195?\\180t?\\194?\\160': 
>> '62d5b8a3-27da-0310-9561-8e5933582275', 'Date de la
>> derni?\\195?\\168re modification': '2011-05-18 21:23:30 +0200
>> (Wed 18 May 2011)', 'R?\\195?\\169vision de la
>> derni?\\195?\\168re modification?\\194?\\160': '121717', 'Racine
>> du d?\\195?\\169p?\\195?\\180t?\\194?\\160': 
>> 'svn://svn.zope.org/repos/main', 'Type de
>> n?\\197?\\147ud?\\194?\\160': 'r?\\195?\\169pertoire',
>> 'T?\\195?\\162che programm?\\195?\\169e?\\194?\\160': 'normale',
>> 'Auteur de la derni?\\195?\\168re modification?\\194?\\160': 
>> 'menesis', 'URL?\\194?\\160': 
>> 'svn://svn.zope.org/repos/main/zope.app.applicationcontrol/trunk/src/zope/app/applicationcontrol/tests',
>>  'Chemin?\\194?\\160': 
>> '/home/ccomb/ztk1.1dev-slave/Python2.7.2-Linux-64bit/build/src/zope.app.applicationcontrol/src/zope/app/applicationcontrol/tests',
>>  'R?\\195?\\169vision?\\194?\\160': '123191'}
> 
>> (Pdb) info.get("Revision", "") ''
> 
>> The key is not the same. It just means the method to read svn
>> data is not robust.


Hmm, there is code in the test which tries to ensure that the locale
for the 'svn' process is set to 'C'::

 $ export ZSVN=svn+ssh://svn.zope.org/repos/main
 $ svn log -r85956 $ZSVN/zope.app.applicationcontrol/trunk
 r85956 | lgs | 2008-05-01 03:37:07 -0400 (Thu, 01 May 2008) | 1 line

 Add a test and a fix for bug 177733, that was causing ZopeVersion to
 report an unknown version when running on a machine with a locale
 different than english
 $ svn diff -c 85956 $ZSVN/zope.app.applicationcontrol/trunk
 ...(elide add of now-failing test)
 --- src/zope/app/applicationcontrol/zopeversion.py...85955)
 +++ src/zope/app/applicationcontrol/zopeversion.py...85956)
 @@ -63,7 +63,7 @@
      def _getSVNInfoOutput(self):
          try:
              proc = subprocess.Popen('svn info "%s"' % self.path,
 -                shell=True, stdout=subprocess.PIPE)
 +                shell=True, stdout=subprocess.PIPE, env={'LANG': 'C'})
          except OSError:
              pass
          else:

I guess it is not clever enough.  Nevertheless, that test was not
failing on any buildslave before yesterday's report.


>> For the Data.fs problem, I had removed all the Data.fs* from all
>> the builders, but they all came back again:
> 
>> ccomb@boa:~$ find . -name 'Data.fs*' 
>> ./ztk1.1-slave/Python2.5.5-Linux-64bit/build/Data.fs.lock 
>> ./ztk1.1-slave/Python2.5.5-Linux-64bit/build/Data.fs.tmp 
>> ./ztk1.1-slave/Python2.5.5-Linux-64bit/build/Data.fs.index 
>> ./ztk1.1-slave/Python2.5.5-Linux-64bit/build/Data.fs 
>> ./ztk1.1-slave/Python2.6.7-Linux-64bit/build/Data.fs.lock 
>> ./ztk1.1-slave/Python2.6.7-Linux-64bit/build/Data.fs.tmp 
>> ./ztk1.1-slave/Python2.6.7-Linux-64bit/build/Data.fs.index 
>> ./ztk1.1-slave/Python2.6.7-Linux-64bit/build/Data.fs 
>> ./ztk1.1-slave/Python2.7.2-Linux-64bit/build/Data.fs.lock 
>> ./ztk1.1-slave/Python2.7.2-Linux-64bit/build/Data.fs.tmp 
>> ./ztk1.1-slave/Python2.7.2-Linux-64bit/build/Data.fs.index 
>> ./ztk1.1-slave/Python2.7.2-Linux-64bit/build/Data.fs 
>> ./ztk1.0dev-slave/Python2.5.5-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.lock
>>
>> 
./ztk1.0dev-slave/Python2.5.5-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.tmp
>> ./ztk1.0dev-slave/Python2.5.5-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.index
>>
>> 
./ztk1.0dev-slave/Python2.5.5-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs
>> ./ztk1.0dev-slave/Python2.6.7-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.lock
>>
>> 
./ztk1.0dev-slave/Python2.6.7-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.tmp
>> ./ztk1.0dev-slave/Python2.6.7-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.index
>>
>> 
./ztk1.0dev-slave/Python2.6.7-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs
>> ./ztk1.0dev-slave/Python2.7.2-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.lock
>>
>> 
./ztk1.0dev-slave/Python2.7.2-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.tmp
>> ./ztk1.0dev-slave/Python2.7.2-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.index
>>
>> 
./ztk1.0dev-slave/Python2.7.2-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs
>> ./ztk1.0dev-slave/Python2.4.6-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.lock
>>
>> 
./ztk1.0dev-slave/Python2.4.6-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.tmp
>> ./ztk1.0dev-slave/Python2.4.6-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.index
>>
>> 
./ztk1.0dev-slave/Python2.4.6-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs
>> ./ztk1.1dev-slave/Python2.5.5-Linux-64bit/build/Data.fs.lock 
>> ./ztk1.1dev-slave/Python2.5.5-Linux-64bit/build/Data.fs.tmp 
>> ./ztk1.1dev-slave/Python2.5.5-Linux-64bit/build/Data.fs.index 
>> ./ztk1.1dev-slave/Python2.5.5-Linux-64bit/build/Data.fs 
>> ./ztk1.1dev-slave/Python2.6.7-Linux-64bit/build/Data.fs.lock 
>> ./ztk1.1dev-slave/Python2.6.7-Linux-64bit/build/Data.fs.tmp 
>> ./ztk1.1dev-slave/Python2.6.7-Linux-64bit/build/Data.fs.index 
>> ./ztk1.1dev-slave/Python2.6.7-Linux-64bit/build/Data.fs 
>> ./ztk1.1dev-slave/Python2.7.2-Linux-64bit/build/Data.fs.lock 
>> ./ztk1.1dev-slave/Python2.7.2-Linux-64bit/build/Data.fs.tmp 
>> ./ztk1.1dev-slave/Python2.7.2-Linux-64bit/build/Data.fs.index 
>> ./ztk1.1dev-slave/Python2.7.2-Linux-64bit/build/Data.fs 
>> ./ztk1.0-slave/Python2.5.5-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.lock
>>
>> 
./ztk1.0-slave/Python2.5.5-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.tmp
>> ./ztk1.0-slave/Python2.5.5-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.index
>>
>> 
./ztk1.0-slave/Python2.5.5-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs
>> ./ztk1.0-slave/Python2.6.7-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.lock
>>
>> 
./ztk1.0-slave/Python2.6.7-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.tmp
>> ./ztk1.0-slave/Python2.6.7-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.index
>>
>> 
./ztk1.0-slave/Python2.6.7-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs
>> ./ztk1.0-slave/Python2.7.2-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.lock
>>
>> 
./ztk1.0-slave/Python2.7.2-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.tmp
>> ./ztk1.0-slave/Python2.7.2-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.index
>>
>> 
./ztk1.0-slave/Python2.7.2-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs
>> ./ztk1.0-slave/Python2.4.6-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.lock
>>
>> 
./ztk1.0-slave/Python2.4.6-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.tmp
>> ./ztk1.0-slave/Python2.4.6-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs.index
>>
>> 
./ztk1.0-slave/Python2.4.6-Linux-64bit/build/parts/test-ztk-zope.session/Data.fs


Those shouldn't be a problem:  the directories which would matter
would be 'parts/test-ztk-zope.testing'.


Tres.
- -- 
===================================================================
Tres Seaver          +1 540-429-0999          [email protected]
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6uxqwACgkQ+gerLs4ltQ7qxACfXx7BSQwKLqhVSClSXZJ6YSoz
qgQAn2Alw9KqeAELuDbFqtQ3Va3vXRRi
=C87R
-----END PGP SIGNATURE-----

_______________________________________________
Zope-Dev maillist  -  [email protected]
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.