Patch for labelfield "validation"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime-oOUblnuQwHKola3qYQ6TW/IULO3mGbRi9nwVQlTi/[email protected] for more info.

--0-1038542614-1114087877=:21108
Content-Type: TEXT/PLAIN; charset=US-ASCII

Hello all,

We had a problem with the PloneFormMailer/Formulator combination we
used. 1.8.0 formulator, 0.22 ploneformmailer.

The problem? Ploneformmailer calls validate() directly on every field
instead of calling the entire form's validation method. Could be done
better, I suppose. This, however, trips a corner case as it raises a
KeyError for labelfield: 'external_validator' is missing.

I've attached a small patch (including an extra unittest) for the
latest version from CVS. Normally, this corner case probably isn't
tripped, but it does make Formulator even more robust. Could this be
added to CVS?

I'm now off looking at PloneFormMailer :-)

Greetings,
Reinout

-- 
Reinout van Rees                  r.van.rees-1kr/[email protected]
http://vanrees.org/weblog/            http://zestsoftware.nl
"engineer: a mechanism for converting caffeine into designs"
--0-1038542614-1114087877=:21108
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="labelfield.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.OSX.4.58.0504211451170.21108-FDbk6sq+xI1WEVQGT4auu4T4S9po1h25@public.gmane.org>
Content-Description: 
Content-Disposition: attachment; filename="labelfield.patch"

ZGlmZiAtcnUgLi4vRm9ybXVsYXRvcl9vcmlnL1ZhbGlkYXRvci5weSAuL1Zh
bGlkYXRvci5weQ0KLS0tIC4uL0Zvcm11bGF0b3Jfb3JpZy9WYWxpZGF0b3Iu
cHkJVGh1IEFwciAyMSAxNDoxMTowNyAyMDA1DQorKysgLi9WYWxpZGF0b3Iu
cHkJVGh1IEFwciAyMSAxNDowNzowNCAyMDA1DQpAQCAtNzY3LDYgKzc2Nywx
MyBAQA0KIGNsYXNzIFN1cHByZXNzVmFsaWRhdG9yKFZhbGlkYXRvckJhc2Up
Og0KICAgICAiIiJBIHZhbGlkYXRvciB0aGF0IGlzIGFjdHVhbGx5IG5vdCB1
c2VkLg0KICAgICAiIiINCisgICAgcHJvcGVydHlfbmFtZXMgPSBWYWxpZGF0
b3JCYXNlLnByb3BlcnR5X25hbWVzICsgWydleHRlcm5hbF92YWxpZGF0b3In
XQ0KKyAgICBleHRlcm5hbF92YWxpZGF0b3IgPSBmaWVsZHMuTWV0aG9kRmll
bGQoJ2V4dGVybmFsX3ZhbGlkYXRvcicsDQorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB0aXRsZT0iRXh0ZXJuYWwgVmFs
aWRhdG9yIiwNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIGRlc2NyaXB0aW9uPSgNCisgICAgICAgICJJZ25vcmVkLCBh
cyBhIHZhbGlkYXRvciBpc24ndCB1c2VkIGhlcmUuIiksDQorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZWZhdWx0PSIi
LA0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgcmVxdWlyZWQ9MCkNCiAgICAgZGVmIG5lZWRfdmFsaWRhdGUoc2VsZiwg
ZmllbGQsIGtleSwgUkVRVUVTVCk6DQogICAgICAgICAiIiJEb24ndCBldmVy
IHZhbGlkYXRlOyBzdXBwcmVzcyByZXN1bHQgaW4gb3V0cHV0Lg0KICAgICAg
ICAgIiIiDQpkaWZmIC1ydSAuLi9Gb3JtdWxhdG9yX29yaWcvdGVzdHMvdGVz
dF9Gb3JtLnB5IC4vdGVzdHMvdGVzdF9Gb3JtLnB5DQotLS0gLi4vRm9ybXVs
YXRvcl9vcmlnL3Rlc3RzL3Rlc3RfRm9ybS5weQlTdW4gRmViIDIwIDIyOjQ1
OjQ2IDIwMDUNCisrKyAuL3Rlc3RzL3Rlc3RfRm9ybS5weQlUaHUgQXByIDIx
IDEzOjI4OjI3IDIwMDUNCkBAIC0xODAsNiArMTgwLDE0IEBADQogICAgICAg
ICAgICAgeydmaWVsZF9pbnRfZmllbGQnOiAnMyd9KQ0KICAgICAgICAgc2Vs
Zi5hc3NlcnRFcXVhbHMoeydpbnRfZmllbGQnOiAzfSwgcmVzdWx0KQ0KIA0K
KyAgICBkZWYgdGVzdF9sYWJlbHNfd2l0aF9kaXJlY3RfdmFsaWRhdGlvbihz
ZWxmKToNCisgICAgICAgICIiIiBQbG9uZUZvcm1NYWlsZXIgY2FsbHMgdmFs
aWRhdGUoKSBkaXJlY3RseSBvbiBlYWNoIGZpZWxkLA0KKyAgICAgICAgdGhp
cyB1c2VkIHRvIGdpdmUgYSBLZXlFcnJvciBhcyAnZXh0ZXJuYWxfdmFsaWRh
dG9yJyB3YXNuJ3QNCisgICAgICAgIGtub3duIGZvciBhIGxhYmVsIGZpZWxk
Lg0KKyAgICAgICAgIiIiDQorICAgICAgICBzZWxmLmZvcm0ubWFuYWdlX2Fk
ZEZpZWxkKA0KKyAgICAgICAgICAgICdsYWJlbF9maWVsZCcsICdUZXN0IExh
YmVsIEZpZWxkJywgJ0xhYmVsRmllbGQnKQ0KKyAgICAgICAgc2VsZi5mb3Jt
WydsYWJlbF9maWVsZCddLnZhbGlkYXRlKFJFUVVFU1Q9RmFrZVJlcXVlc3Qo
KSkNCiANCiAgICAgZGVmIHRlc3RfZGF0ZXRpbWVfY3NzX2NsYXNzX3JlbmRl
cmluZyhzZWxmKToNCiAgICAgICAgICMgdGVzdCB0aGF0IGEgYnVnIGlzIGZp
eGVkLCB3aGljaCBjYXVzaW5nIHRoZSBjc3NfY2xhc3MgdmFsdWUNCg==

--0-1038542614-1114087877=:21108
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
formulator-dev mailing list
formulator-dev-IAPFreCvJWM6s/[email protected]
http://lists.infrae.com/mailman/listinfo/formulator-dev

--0-1038542614-1114087877=:21108--