Pending patch to some "CheckBoxField" issue
Clemens Robbenhaar <robbenhaar-WaVJUzJ3u31Wk0Htik3J/[email protected]> Fri, 21 May 2004 16:06:18 +0200
| Newsgroups | gmane.comp.web.zope.formulator.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, there is patch for the checkbox-field issue, where a checkbox, which is checked by default, will be checked when the form is rerendered after submitting it, even if the user did uncheck the box before submit: http://sourceforge.net/tracker/index.php?func=detail&aid=952128&group_id=27810&atid=391592 Ususally I have the tendency to commit patches to the CVS if they are straight fixing bugs, but I am not sure about this one. Actually I do not like the fact it does something like "oh, we have a CheckBox here, treat it special", though this is somewhat academic and I do not have a good idea how to fix the issue without that special treatment. The other problem is that this patch seems not to fix the issue in the case where not the complete form is rendered by formulator, but only its fields (by looping over all fields). I guess rendering the fields separately is the more common use for Formulator now, as this allows to put layout in between the fields. If this happens, the hidden "formulator_submit" field will not be present. (At least I guess it is not, I admit that I did not really test this.) I remember loosely there has been some discussion about this issue (but not the current patch) in the context of Silva, but I failed to remember if there has been some conclusion about it. Can someone help my old stupid brain about it? I would like to get this checkbox issue away as it has bitten me several times in the past, but I really do not know what to do here, and cannot remember what the opinion of others are regarding this issue. (btw, should I post this to silva-dev, too? Even if it is off topic there, maybe it will reach some "affected" developers there.) Cheers, Clemens