r13496 - in Products.PortalTransforms/trunk: . Products/PortalTransforms

Author: davisagli
Date: Sat Feb 26 23:02:57 2011
New Revision: 13496

Modified:
   Products.PortalTransforms/trunk/CHANGES.txt
   Products.PortalTransforms/trunk/Products/PortalTransforms/TransformEngine.py
Log:
fix protection of convertTo

Modified: Products.PortalTransforms/trunk/CHANGES.txt
==============================================================================
--- Products.PortalTransforms/trunk/CHANGES.txt	(original)
+++ Products.PortalTransforms/trunk/CHANGES.txt	Sat Feb 26 23:02:57 2011
@@ -4,6 +4,10 @@
 2.0.5 - Unreleased
 ------------------
 
+- Fix regression due to the security declarations added in 2.0.4: convertTo
+  should still be public, but not publishable.
+  [davisagli]
+
 2.0.4 - 2011-02-25
 ------------------
 

Modified: Products.PortalTransforms/trunk/Products/PortalTransforms/TransformEngine.py
==============================================================================
--- Products.PortalTransforms/trunk/Products/PortalTransforms/TransformEngine.py	(original)
+++ Products.PortalTransforms/trunk/Products/PortalTransforms/TransformEngine.py	Sat Feb 26 23:02:57 2011
@@ -79,7 +79,7 @@
         if name in self.objectIds():
             self._delObject(name)
 
-    security.declarePrivate('convertTo')
+    security.declarePublic('convertTo')
     def convertTo(self, target_mimetype, orig, data=None, object=None,
                   usedby=None, context=None, **kwargs):
         """Convert orig to a given mimetype
@@ -179,6 +179,8 @@
 
         # return IDataStream object
         return result
+    # make sure it's not publishable (XSS risk)
+    del convertTo.__doc__
 
     security.declarePublic('convertToData')
     def convertToData(self, target_mimetype, orig, data=None, object=None,

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev