r13726 - in archetypes.kss/trunk: archetypes/kss docs

Author: vincentfretin
Date: Mon Jul 18 16:09:20 2011
New Revision: 13726

Modified:
   archetypes.kss/trunk/archetypes/kss/validation.py
   archetypes.kss/trunk/docs/HISTORY.txt
Log:
The change introduced in r12412 is completely wrong, it clears the fieldErrorBox instead of showing the error message. We don't only have the 'required message' with validators... I changed the warning_only parameter to False to show again the error message.

Modified: archetypes.kss/trunk/archetypes/kss/validation.py
==============================================================================
--- archetypes.kss/trunk/archetypes/kss/validation.py	(original)
+++ archetypes.kss/trunk/archetypes/kss/validation.py	Mon Jul 18 16:09:20 2011
@@ -65,7 +65,7 @@
         if isinstance(error, str):
             error = error.decode('utf', 'replace')
         # replace the error on the page
-        self.getCommandSet('atvalidation').issueFieldError(fieldname, error, warning_only=True)
+        self.getCommandSet('atvalidation').issueFieldError(fieldname, error, warning_only=False)
         return self.render()
 
     # XXX full form validation

Modified: archetypes.kss/trunk/docs/HISTORY.txt
==============================================================================
--- archetypes.kss/trunk/docs/HISTORY.txt	(original)
+++ archetypes.kss/trunk/docs/HISTORY.txt	Mon Jul 18 16:09:20 2011
@@ -4,6 +4,14 @@
 1.7.1 (Unreleased)
 ------------------
 
+- The change r12412 in 1.6.0a3 introduced a regression,
+  the field inline validating error message was not shown to the user.
+  The error message is not always the "required field" message, so it's
+  problematic to not show the error message in all cases.
+  The warning_only parameter is now set to False in the issueFieldError call so
+  the error message appears again.
+  [vincentfretin]
+
 1.7.0 (2011-01-03)
 ------------------
 

------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric 
Ries, the creator of the Lean Startup Methodology on "Lean Startup 
Secrets Revealed." This video shows you how to validate your ideas, 
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev