Re: [Plone-developers] [svn-changes-z4DKO/[email protected]: [Archetypes-checkins] r5336 - Archetypes/branches/release-1_3-branch/skins/archetypes/widgets]
Wichert Akkerman <[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.archetypes.devel,gmane.comp.web.zope.plone.devel |
|---|---|
| Message-ID | <[email protected]> |
Previously Sidnei da Silva wrote: > Someone should look at this. Code like this is potentially expensive > with FileField/TextField containing large files. Put it this way, the > file contents will be completely loaded in memory. If you have a 100mb > file, you know what will happen. I guess the difference here is the added call to get_size, since that will call ObjectField.getRaw? An alternative approach in this could would be to check if getFilename returns non-None. Is that acceptable? Wichert. -- Wichert Akkerman <[email protected]> It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click