Re: r5964 - Archetypes/branches/release-1_3-branch
Rob Miller <ra-UE+B0n23d/[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.archetypes.devel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 17 Feb 2006 23:44:42 -0200, Dorneles Treméa wrote: > Hey Rob, > >> Author: rafrombrc >> Date: Fri Feb 17 18:44:36 2006 >> New Revision: 5964 >> >> Modified: >> Archetypes/branches/release-1_3-branch/Field.py >> Log: >> * adding 'raw=True' to the self.get() call in download has no effect on >> FileField, but it makes the download method work correctly on >> TextFields >> >> >> >> Modified: Archetypes/branches/release-1_3-branch/Field.py >> ============================================================================== >> --- Archetypes/branches/release-1_3-branch/Field.py (original) +++ >> Archetypes/branches/release-1_3-branch/Field.py Fri Feb 17 18:44:36 2006 >> @@ -1067,7 +1067,7 @@ >> >> Writes data including file name and content type to RESPONSE >> """ >> - file = self.get(instance) >> + file = self.get(instance, raw=True) >> if not REQUEST: >> REQUEST = instance.REQUEST >> if not RESPONSE: > > sorry for being picky, no problem. :-). > but where's the test that show us the issue? ;-) i've committed a test that demonstrates the fix. i needed to add a 'no_output' argument to the download method to be able to verify that the behaviour was as expected. -r ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642