Re: Patch: HistoricalRevisions, atct_history support for annotation storage (used by newer ATCT)
"Martin Aspeli" <[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.archetypes.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 08 Mar 2006 14:32:11 -0000, Matt Hahnfeld <[email protected]> wrote: >> Does this mean that the history tab starts working again for ATDocument >> (Page), event, news etc. types? > > Yes. I tested the history tab in the ZMI and atct_history (the plone > ATCT > hisotry tab) and both work great. Fantastic. I know limi is really keen on this coming back sooner rather than later. > Be sure to get my little patch for atct_history, which I appended to the > ticket this morning: > > http://dev.plone.org/archetypes/ticket/648 > > I have not written any automated tests for the patches (truth be told, > I'm > a Perl guy, and I haven't written much production code under Python -- I > still need to learn how to write tests). I'd be happy to add some tests > as soon as I get a chance. > > So, you think a monkey patch might be the way to go? I'm unsure. I'd prefer it if the patch went into Zope. But you will have to provide solid unit tests to convince people your patch isn't dangerous. Take a look at http://plone.org/documentation/tutorial/testing (although tests for Zope itself will probably have to use ZopeTestCase directly, not PloneTestCase). I'd like to hear from Jensens and possibly Alec Mitchell what they think, though. Martin -- (muted) ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642