Re: Patch: HistoricalRevisions, atct_history support for annotation storage (used by newer ATCT)

On Thu, 09 Mar 2006 20:41:52 +0000, Martin Aspeli wrote:

>> If this is going to go into Zope, which I think it should, we need to
>> find a more generic way to handle the issue.  The current patch is short
>> and simple, but it only handles __annotation__ attributes.  It provides a
>> very simple fix for the issue at hand (and actually works very well for
>> our needs!), but probably isn't something the Zope folks would want to  
>> add
>> to Zope.
>
> I see the problem. Perhaps we can replicate some of this code at the AT  
> storage level and not have to use OFS.* directly at all instead?

Martin --

Thanks for the feedback!

The original patch could probably be pulled up into the ATCT layer
(historyaware.py).  It essentially just checks the historical revision of
an object for the '__annotation__' property, and if that property exists
it updates each node of object['__annotation__'] (a OOBtree) with its
historical revision.  Remember, each subobject (in this case, each node of
a OOBtree) is versioned separately in the ZODB.

Unfortuantely, if we decided to patch historyaware.py instead of Zope then
only the atct_history tab would work.  We would lose the ability to look
at a page at an arbitrary point in time, or after a particular edit. Those
features are currently accomplished through history_form (Plone) or the
history tab in the ZMI (Zope).  I guess we could pull those features into
AT/ATCT somehow, but then this turns into a pretty big project -- and
ultimately Zope remains broken.

Ideally, I think we should still look towards patching Zope...

Matt



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642