Re: Patch: HistoricalRevisions, atct_history support for annotation storage (used by newer ATCT)

Matt Hahnfeld wrote:
>>On Thu, 09 Mar 2006 20:41:52 +0000, Martin Aspeli wrote:
>>

Hi Matt,

this is all very interesting ...

[..]
> Below is a proof of concept for a generic low-level solution.  I
> implemented it as its own separate class, but it could probably subclass
> the ZODB serializer, since it's almost entirely copied from there.  In my
> testing, it works for ATDocuments (using annotation storage) on a clean
> Plone 2.1.2/Zope 2.8.5 site using "zopectl debug".  I haven't had time to
> test much beyond that (feedback welcome!).  It should work for other AT
> field storages that use subobjects too (are there any?).

You mean like the MetadataStorge which uses a '_md' dict on the object?

> 
> Because of the way this is implemented, something like this could probably
> be a part of the AT or ATCT layer -- if it wasn't included in Zope.  As
> you can see, this class essentially just overrides the Unpickler's
> persistent_load to provide old versions of subobjects (err...  references
> to other objects) when they are loaded from the ZODB. I also removed all
> caching functionality, since you wouldn't want to use the cache when
> you're getting a historical revision.

I think this shouldn't be patched by AT but moved into the
ZODB if possible. Do you know that there is a dedicated
ZODB list: [email protected]

Did you post this there as well? This is where you will
reach our gurus like Jim, Tim, or Dieter who I'm sure will
know whether there are issues or not.

Thanks for looking into this,

	Raphael





-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642