Re: RFC822Marshaller for all content uploaded with FTP/Webdav

On Tue, 2006-05-02 at 14:19 -0300, Sidnei da Silva wrote:
> On Tue, May 02, 2006 at 07:12:23PM +0200, Roché Compaan wrote:
> | One of our clients alerted us to their FTP problems a couple of days
> | ago. They upload plain text log files into Plone which worked in the
> | days before ATContentTypes but now it is broken.
> | 
> | After investigation it seems that all files that are uploaded via FTP or
> | Webdav are demarshalled using the RFC822Marshaller. I realise that I
> | might eat my words later on, but whoever implemented this must have been
> | drunk at the time ;-)
> | 
> | As expected weird things happen  with this implementation, the whole
> | file ends up being parsed as 'headers' and FTP commands end up in
> | 'body'.
> | 
> | As a sanity double check and before I try to work out a reasonable
> | implementation can I ask if this is intended????
> 
> It was intended a the time, but proved being a bad choice later
> on. Note this is the default for Document and News Item in CMFDefault,
> but not for Image and File. The distinction makes it even harder.
> 
> Limi has given his approval for me to fix this to have more saner
> defaults, but I've been a bit busy lately. I hope to still find time
> this month to do it.
> 
> If you want to discuss what 'saner defaults' should be defined as,
> and maybe write a PLIP, that would ease my job a lot.

I won't have time to write a PLIP and I need to fix this for the client
now. I'd like to fix this in a way that might be usable by you.

I am hoping for an implementation that is a bit more intelligent as
opposed to just having good defaults. IMO a very simple fix would be to
not try to demarshall a file using RFC822Marshaller if it is not
appropriate. Maybe even better would be to have an über marshaller that
uses RFC882 when appropriate and upload files that are clearly not
RFC822 compliant as files, not Plone documents.

If we talk enough in this thread, we might say enough to derive a PLIP
from :-)

-- 
Roché Compaan
Upfront Systems                   http://www.upfrontsystems.co.za



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642