Re: PdataStreamIterator bug?
Roché Compaan <roche-kb4xc5yObU3kQYj/0HfcvhBnub05S5/[email protected]> Thu, 25 May 2006 16:10:49 +0200
| Newsgroups | gmane.comp.web.zope.plone.archetypes.devel |
|---|---|
| Organization | Upfront Systems |
| Message-ID | <[email protected]> |
On Thu, 2006-05-25 at 10:41 -0300, Sidnei da Silva wrote: > On Thu, May 25, 2006 at 03:17:35PM +0200, Roché Compaan wrote: > | I've looked at the latest version and I don't quite understand the > | rationale behind the implementation. Why is it necessary to read the > | whole file into a temporary file, if it can be streamed by iterating > | over the Pdata chain. This will keep memory consumption low, and will be > | much more responsive from the clients point of view - waiting for N > | gigabyte to be written to a tempfile first can take a while. > > That's what it did before. That broke ExternalEditor. The current > version works with ExternalEditor and keeps the memory low. I can't see how it can make any difference. What does it matter where you stream the file from? At the moment you're streaming it from a tempfile, how can streaming it from a chain of Pdata objects break ExternalEditor? -- Roché Compaan Upfront Systems http://www.upfrontsystems.co.za ------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid7521&bid$8729&dat1642