Products.CMFPlone/hvelarde-no-new-tabs: Do not open links on a new tab as this is against all basic

Repository: Products.CMFPlone
Branch: refs/heads/hvelarde-no-new-tabs
Date: 2017-07-28T17:39:02-03:00
Author: hvelarde (hvelarde) <[email protected]>
Commit: https://github.com/plone/Products.CMFPlone/commit/d05bf2908052b9b50d941411de7f244c276aecf8

Do not open links on a new tab as this is against all basic usability guidelines

See: https://www.nngroup.com/articles/the-top-ten-web-design-mistakes-of-1999/

Files changed:
M CHANGES.rst
M Products/CMFPlone/browser/templates/plone-overview.pt
M Products/CMFPlone/browser/templates/plone-upgrade.pt

diff --git a/CHANGES.rst b/CHANGES.rst
index 9ba995af6..d4cc19604 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,7 +10,7 @@ Changelog
 
 Breaking changes:
 
-- Replaced cssmin with PyScss to ensure Python 3 compatibility and maintainability. 
+- Replaced cssmin with PyScss to ensure Python 3 compatibility and maintainability.
   Removed dependency to cssmin, so could break dependency for third party addons that depend on it.
   Introduced PyScss as a drop in replacement that could also do more things.
   Discussion on that at https://github.com/plone/Products.CMFPlone/issues/1800
@@ -29,6 +29,9 @@ New features:
 
 Bug fixes:
 
+- Do not open links on a new tab as this is against basic usability guidelines.
+  [hvelarde]
+
 - add :focus class on toolbar for keyboard users  (https://github.com/plone/Products.CMFPlone/issues/1620)
   [polyester]
 
diff --git a/Products/CMFPlone/browser/templates/plone-overview.pt b/Products/CMFPlone/browser/templates/plone-overview.pt
index b179f879d..7115cbe29 100644
--- a/Products/CMFPlone/browser/templates/plone-overview.pt
+++ b/Products/CMFPlone/browser/templates/plone-overview.pt
@@ -152,7 +152,6 @@
       <span i18n:translate="label_plone_org_description"> For documentation, add-ons, support, community, visit</span>
       <a href="http://plone.org"
         title="Plone Community Home"
-        target="_new"
         i18n:attributes="title label_plone_org_title;">plone.org</a>.
     </p>
   </footer>
diff --git a/Products/CMFPlone/browser/templates/plone-upgrade.pt b/Products/CMFPlone/browser/templates/plone-upgrade.pt
index d08c1b309..2ac449fd1 100644
--- a/Products/CMFPlone/browser/templates/plone-upgrade.pt
+++ b/Products/CMFPlone/browser/templates/plone-upgrade.pt
@@ -31,7 +31,6 @@
   <h1 i18n:translate="">Upgrade this site</h1>
   <h1>
       <a href="#"
-         target="_new"
          tal:attributes="href context/absolute_url;
                          title context/Title;"
          tal:content="context/Title">
@@ -44,7 +43,6 @@
     More information about the upgrade procedure can be found in the
     documentation section of plone.org in the
     <a href="http://docs.plone.org/manage/upgrading"
-       target="_new"
        i18n:name="upgrade_guide"
        i18n:translate="">Upgrade Guide</a>.
   </p>



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot