Products.CMFPlone/issue-1376-controlpanel-permissions-50: Fixed accidentally removing permissions when saving portal_c

Repository: Products.CMFPlone
Branch: refs/heads/issue-1376-controlpanel-permissions-50
Date: 2017-08-02T18:44:58+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: https://github.com/plone/Products.CMFPlone/commit/6aefd957e81761fe9a88321df240dd22f2b47002

Fixed accidentally removing permissions when saving portal_controlpanel in ZMI.

Fixes https://github.com/plone/Products.CMFPlone/issues/1376.

Files changed:
M CHANGES.rst
M Products/CMFPlone/PloneControlPanel.py

diff --git a/CHANGES.rst b/CHANGES.rst
index 29829e155..db978d5a8 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -12,6 +12,40 @@ Changelog
 Breaking changes:
 
 - *add item here*
+- Replaced cssmin with PyScss to ensure Python 3 compatibility and maintainability.
+  Removed dependency to cssmin, so could break dependency for third party addons that depend on it.
+  Introduced PyScss as a drop in replacement that could also do more things.
+  Discussion on that at https://github.com/plone/Products.CMFPlone/issues/1800
+  [loechel]
+- Fix and migrate safe_html filter completly into Plone registry and sync settings with TinyMCE.
+  Also some unused options in controlpanel where removed, like stripped_combinations and class_blacklist.
+  [MrTango]
+
+New features:
+
+- Added ``Show Toolbar`` permission.
+  [agitator]
+
+- Add RobotFramework screenshot tests for the Plone documentation.
+  [datakurre, polyester]
+
+Bug fixes:
+
+- Fixed accidentally removing permissions when saving the ``portal_controlpanel`` settings in the ZMI.
+  Fixes `issue 1376 <https://github.com/plone/Products.CMFPlone/issues/1376>`_.  [maurits]
+
+- Do not open links on a new tab as this is against basic usability guidelines.
+  [hvelarde]
+
+- add :focus class on toolbar for keyboard users  (https://github.com/plone/Products.CMFPlone/issues/1620)
+  [polyester]
+
+- Fix empty DX add_forms if formlib is also installed thru addon dependencies
+  [MrTango]
+
+
+5.1b4 (2017-07-03)
+------------------
 
 New features:
 
diff --git a/Products/CMFPlone/PloneControlPanel.py b/Products/CMFPlone/PloneControlPanel.py
index 73ccf97dd..15be1a071 100644
--- a/Products/CMFPlone/PloneControlPanel.py
+++ b/Products/CMFPlone/PloneControlPanel.py
@@ -194,7 +194,7 @@ def _extractAction(self, properties, index):
             except ValueError:
                 visible = 0
 
-        if not isinstance(permissions, basestring):
+        if isinstance(permissions, basestring):
             permissions = (permissions, )
 
         return PloneConfiglet(id=id,



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot