Re: FWT meeting notes 2013-06-25

Am 01.07.2013 01:40, schrieb David Glick (Plone):
> On 6/28/13 11:24 AM, Rok Garbas wrote:
>> Quoting David Glick (Plone) (2013-06-28 19:07:21)
>>> On 6/28/13 5:08 AM, Rok Garbas wrote:
>>>> Quoting Martin Aspeli (2013-06-28 09:56:34)
>>>>> Maybe some things (like the Diazo editor) should not be in overlays
>>>>> ever, but
>>>>> open in a full frame and set X-Theme-Diasabled (?) so they are not
>>>>> themed.
>>>> i would only consider this as a temporary solution, until we equipt
>>>> it with
>>>> tests (and we need to do this as soon as possible) and create
>>>> pattern out of it
>>>> (that mean it will work in overlay). also note that overlay can be
>>>> also fully
>>>> stretched through whole window and is not an overlay anymore from UI
>>>> perspective.
>>>>
>>> I don't understand why we should go to the bother of making it be an
>>> overlay then?
>> i think i'm just not explaining well.
>>
>> to create a pattern out of current code means we'll create code that
>> can be
>> tested and loaded in any part of the DOM. same thing we already did
>> for all
>> other javascript that we rewrote/review and wrote also tests for it.
>>
>> i think we all agree that we must have tests for Diazo Editor as well,
>> right?
>> i really want to push to have all javascript in Plone tested for 5.0.
>>
>> and if we create a patterns out of Diazo Editor that means we can show
>> Diazo
>> Editor in overlay, because patterns gives us control when some code is
>> executed, automaticaly.
>>
>> maybe misleading is the name overlay. because from UI point of you
>> this overlay
>> can have full width and full height of the browser window. and then
>> you can not
>> call it overlay (from UI point of view). but from technical point of
>> view this
>> still is an overlay, just stretched over whole window.
>>
> I agree that we should work on improving our javascript test coverage,
> but I think the best path to doing so while shipping a usable
> plone.app.toolbar ASAP is:
> 1. Make control panels load as full page loads, rather than as an
> overlay. plone.app.toolbar can install a prefs_main_template that uses a
> toolbar theme instead of the theme used by the content.
> 2. Ship it.
> 3. Work on converting control panel-related scripts to patterns with
> tests. This can happen gradually.
> 4. But never switch to loading control panels in an overlay. Or at
> least, control panels have to opt in to being loaded in an overlay (but
> I haven't heard any reason for why that's beneficial). This way add-ons
> that use their own javascript on their own control panels (yes, they
> exist) won't break when you install plone.app.toolbar.

+1

Timo




------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev