review for fixes of bugs due to acquisition black magic
Godefroid Chapelle <[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi all, I committed fixes in 4.3.x branch for two nasty acquisition bugs. I'd like to get some feedback : - https://github.com/plone/Products.CMFPlone/commit/e20ea907d2854ee7ad41e9953b64889ee7431b49 is a fix for https://dev.plone.org/ticket/13793 but it might break some sites that have wrongly built URLS, iow URLS where content is currently made accessible through acquisition. - https://github.com/plone/Products.CMFPlone/commit/6d6710728b35b97e2f328c454c8688346612b1e1 is a fix for https://dev.plone.org/ticket/13603 but it breaks backward compatibility by forbidding use of relative paths. In both cases, I think that not fixing the bug is worse than the side-effect of the fix. But maybe some of you disagree... or have ideas for better fixes. Looking forward to hearing from you all. -- Godefroid Chapelle (aka __gotcha) http://bubblenet.be ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk