Re: Plone 5 Theme

On Thursday, November 14, 2013 at 8:53 PM, Johannes Raggam wrote:
> On Don, 2013-11-14 at 16:10 -0800, David Glick (Plone) wrote:
> > On 11/14/13, 4:04 PM, polyester wrote:
> > > On 14-11-13 23:25, Ramon Navarro Bosch wrote:
> > > 
> > > > * DL/DT/DD: this tags on HTML5 are defined to be used on definitions of
> > > > concepts, so on semantic world doesn't make any sense to have them where
> > > > are used (status message, content actions, ... ) so my idea is to remove
> > > > them. I already removed some of them on the main_template branches plip
> > > > but before continuing I thought about asking opinions. This change means
> > > > that we will have a broken build ( it involves so many tests ) and needs
> > > > to go deep on the different templates. (right now main_template jenkins
> > > > job is broken because of that)
> > > > 
> > > 
> > > Our prolific use of DL/DT/DD was/is also a problem for a11y; they are
> > > currently (4.x) used in portlets way too much. They should go.
> > > Accessibility tests do not look kindly upon using DL and allies in
> > > non-meaningful ways.
> > > 
> > > During PSM, the people working on accessibility already agreed they
> > > should be taken out of portlets. But since that would break lots of
> > > stuff, it was decided it should wait until Plone5.
> > > 
> > > So yes, by all means, remove them. They should be removed from all
> > > portlets as well. Will see what I can do to remove them wholesale from
> > > all portlets we ship with.
> > > 
> > > It may break tests, but it breaks a11y in more serious ways. So better
> > > to remove them, and fix the tests.
> > > 
> > 
> > What markup is preferred? Maybe something like this for portlets:
> > 
> > <aside class="portlet">
> > <header>asdf</header>
> > <section class="portletItem">asdf</section>
> > <footer><a href="...">Read more...</a></footer>
> > </aside>
> > 
> 
> 
> +1 for removing the definition lists and using the proposal above.
> 
> fixing tests is a massive amount of effort, tough. we should find a
> strategy how to fix this.
> 
> 

Since the theme is a roadblock to any early releases at this point, I'd like to clear as much out of Ramon's way as possible. So I'd like to give him a pass on any failing tests for now. As we approach the point at which it can be merged, we'll organize an afternoon (or local time equivalent) of test fixing. Since this is going to be a largely repetitive task, I'd think 4-8 people could blast through the failures fairly quickly. 

Thanks, Ramon, for taking this on. It's looking great.

------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk

_______________________________________________
Plone-developers mailing list
Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/plone-developers