Re: syndication and rendering of content

Hi Juan,

Thanks for the help in implementing this!

This looks familiar to how franco implemented newsml and I had told him it
was the incorrect way to do so.

You should not need to have an newsml specific folder and collection
adapters. It also looks like you have duplicated code. Anything custom to
how newsml is rendered should go into NewsMLFeedView

I do not think the newsml_enabled_types option is necessary either.

As for rendering the content body, didn't we also want title and
description in there? Maybe we should render the content-main macro?

Your thoughts to my comments?


Thanks,
Nathan


On Wed, Jan 8, 2014 at 7:59 AM, Juan Pablo Giménez <[email protected]> wrote:

> Hi,
>
>   I just ported the c.syndication code to
> https://github.com/plone/Products.CMFPlone/tree/syndication_improvementsand implemented an upgrade step @
> https://github.com/plone/plone.app.upgrade/tree/syndication_improvements
>   This way Plone 4.3 supports NewsML feeds and implement the improvements
> to "render body" functionality.
>   Now, should I do a pull request for both products?
>
>
> cheers!
> --
> Juan Pablo Giménez
> skype & twitter: jpggimenez
> Simples Consultoria <http://simplesconsultoria.com.br/>
>
>


-- 
Nathan Van Gheem
Solutions Architect
Wildcard Corp

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk

_______________________________________________
Plone-developers mailing list
Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/plone-developers