Re: syndication and rendering of content
Nathan Van Gheem <[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.devel |
|---|---|
| Message-ID | <CAL8hw9GCFz9cagVVH6vRWH8NU6EKZAvAoir9aacBgZCKL0sz8A@mail.gmail.com> |
Looks better. One last comment, can you remove newsml_enabled from the utility and just put that logic also in the view? Then, finally, add a test for the newsml feed and make sure the tests are passing still? Feel free to merge it after that. Thanks! On Wed, Jan 15, 2014 at 11:09 AM, Juan Pablo Giménez <[email protected]>wrote: > 2014/1/9 Juan Pablo Giménez <[email protected]> > >> >> 2014/1/9 Nathan Van Gheem <[email protected]> >> >>> Hi Juan, >>> >>> Thanks for the help in implementing this! >>> >>> This looks familiar to how franco implemented newsml and I had told him >>> it was the incorrect way to do so. >>> >>> You should not need to have an newsml specific folder and collection >>> adapters. It also looks like you have duplicated code. Anything custom to >>> how newsml is rendered should go into NewsMLFeedView >>> >> >> Agreed, I was just porting code, but you're right we could simplify it... >> maybe was ok and working for a collective product, should be improved to >> get into the core... I can do it... >> >> >>> >>> I do not think the newsml_enabled_types option is necessary either. >>> >> >> Agreed, >> > > Hi Nathan, > > I fixed that in this commit, > https://github.com/plone/Products.CMFPlone/commit/bd3c54094dbf2a817d1443627d8aa19475a3c664 > Now everything is handled in the view. You can review the changes in > this pull request, https://github.com/plone/Products.CMFPlone/pull/151 > > cheers, > jpg > -- Nathan Van Gheem Solutions Architect Wildcard Corp ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Plone-developers mailing list Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/plone-developers