Re: syndication and rendering of content

2014-01-21 11:17 GMT-03:00 Nathan Van Gheem <[email protected]>:

> You could only import that one field but that should be fine I think.
>
> Could you also make sure that the code that pulls in that setting, handles
> it safely if the registry setting isn't there(so we don't break sites
> during an upgrade)? You'll want to look at
> Products.CMFPlone.browser.syndication.settings. I might actually handle bad
> values already--I'm not sure--just check.
>
>
I was testing this, but no... syndication settings doesn't play nicely if
the registry is not actualized, because it simple access the registry for
the interface and plone.registry breaks with a KeyError... I think than
this could be handled into FeedSettings class (
https://github.com/plone/Products.CMFPlone/blob/syndication_improvements/Products/CMFPlone/browser/syndication/settings.py#L28),
accessing default values if the registry returns a KeyError, but I'm not
sure than that could be a good fix, the user could end up thinking than the
upgrade overrides the syndication configuration, will try to reconfigure
and could generate more problems than it fix... so, IMHO leaving it break
until the user runs the plone-upgrade should be better...

cheers,
jpg

------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk

_______________________________________________
Plone-developers mailing list
Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/plone-developers