Re: New p.r.zeoserver release w/Buildout 2 support

On 2/23/14, 3:11 PM, Alex Clark wrote:
> On 2/23/14, 1:46 PM, Alessandro Pisa wrote:
>> On 23 February 2014 14:28, Alex Clark <[email protected]> wrote:
>>> Hi all,
>>>
>>>
>>> Can someone please review/merge/release this?
>>> https://github.com/plone/plone.recipe.zeoserver/pull/6 (add support for
>>> Buildout 2)
>>>
>>> Else please give me PyPI roles so I can do it
>>>
>>
>> Does this patch fixes plone.recipe.zeoserver when working with a pip
>> installed zc.buildout?
>
>
> Yes, although I didn't realize it was a Pip vs. Buildout issue until
> now. For whatever God-awful reason, the following Plone installation
> process:
>
>
> $ virtualenv .
> $ bin/pip install zc.buildout
> $ bin/buildout init
>
> causes the following traceback (with a Plone buildout like
> https://raw.github.com/plock/pins/master/plone-4-3):
>
>
> ---
>
> aclark@Alexs-MacBook-Air:/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/
>   > bin/buildout
> Uninstalling plone.
> Installing plone.
> Generated script
> '/private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/bin/plone'.
> Generated interpreter
> '/private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/plone/bin/interpreter'.
> Installing zeo.
> Created directory
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo
> Created directory
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo/etc
> Created directory
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo/var
> Created directory
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo/log
> Created directory
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo/bin
> Wrote file
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo/etc/zeo.conf
> Wrote file
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo/bin/zeoctl
> Changed mode for
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo/bin/zeoctl
> to 755
> Wrote file
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo/bin/runzeo
> Changed mode for
> /private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/parts/zeo/bin/runzeo
> to 755
> Generated script
> '/private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/bin/zeo'.
> While:
>     Installing zeo.
>
> An internal error occurred due to a bug in either zc.buildout or in a
> recipe being used:
> Traceback (most recent call last):
>     File
> "/private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/lib/python2.7/site-packages/zc/buildout/buildout.py",
> line 1942, in main
>       getattr(buildout, command)(args)
>     File
> "/private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/lib/python2.7/site-packages/zc/buildout/buildout.py",
> line 622, in install
>       installed_files = self[part]._call(recipe.install)
>     File
> "/private/var/folders/1k/fmmlqcfn5jsbcqrqsw3q_slm0000gn/T/tmpuJ23kF/lib/python2.7/site-packages/zc/buildout/buildout.py",
> line 1366, in _call
>       return f()
>     File
> "/Users/aclark/Developer/eggs-directory/plone.recipe.zeoserver-1.2.6-py2.7.egg/plone/recipe/zeoserver/__init__.py",
> line 97, in install
>       self.install_scripts()
>     File
> "/Users/aclark/Developer/eggs-directory/plone.recipe.zeoserver-1.2.6-py2.7.egg/plone/recipe/zeoserver/__init__.py",
> line 383, in install_scripts
>       extra_paths.append(ws.by_key['zc.buildout'].location)
> KeyError: 'zc.buildout'
>
>
> ---
>
>
>
> So this PR aims to fix that. I will updated the PR to reflect the fact
> that it's Pip-installed-zc.buildout-issue and not a Buildout 2 issue.


Done: 
https://github.com/plone/plone.recipe.zeoserver/commit/95cc69aa5afa6a2d567bc58c412d300b1e95004b

And to be clear I should mention the error occurs when I use a buildout 
that actually uses the zeoserver recipe ;-). The one I listed above doesn't.

E.g.:

[buildout]
extends =
   https://raw.github.com/plock/pins/master/plone-4-3
   https://raw.github.com/plock/pins/master/zeo


>
>
>
>>
>> Ciao
>>
>
>


-- 
Alex Clark · http://about.me/alex.clark


------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk