Re: Shouldn't plone.portlet.collection 2.2.x be 3.0.x

4.3 is using the 2.1.x branch and 5.0 is using master/2.2.x. There's no 
worry about breaking pre-5.0 releases, just a question of what the 
version number should be. I've been generally trying to move packages to 
sane versions (i.e. no more 0.6.6-type releases) as I get to them, but I 
can certainly be a lot more picky about it.

Eric

On 5 Mar 2014, at 10:18, Anthony Gerrard wrote:

> I was thinking this commit
>
> https://github.com/plone/plone.portlet.collection/commit/512e77404de0a4dd77b681102219363058831bbc
>
> It pulls in plone.app.contenttypes although admittedly only for tests 
> so
> maybe that doesn't count.
>
>
> On 5 March 2014 14:25, Johannes Raggam <[email protected]> wrote:
>
>> which changes are your referring? the one you recently did?
>> just by reading the last few changes in CHANGES.rst, i cant see very 
>> big
>> changes.
>>
>> but in general i agree. backwards incompatible changes should make a
>> major release - except restoring compatibility is trivial. we should
>> include a statement like this in:
>>
>> https://github.com/plone/plone.api/blob/master/docs/contribute/conventions.rst#versioning-schemethis 
>> document might become the official code guidelines of Plone, at least
>> that's what we plan for Plone 5.
>>
>> pull-requests 3+4 would make a good 3.0.x release:
>> https://github.com/plone/plone.portlet.collection/pulls
>>
>> best, johannes
>>
>>
>> On Wed, 2014-03-05 at 11:01 +0000, Anthony Gerrard wrote:
>>> Hi,
>>>
>>>
>>> It looks like the changes made to the master branch on
>>> plone.portlet.collection break backwards compatibility with plone
>>> 4.3.x.
>>>
>>>
>>> Shouldn't the releases be called 3.0.x and not 2.2.x? Do we have a
>>> versioning policy written down for plone packages?
>>>
>>>
>>>
>>> Anthony
>>>
>> ------------------------------------------------------------------------------
>>> Subversion Kills Productivity. Get off Subversion & Make the Move to
>> Perforce.
>>> With Perforce, you get hassle-free workflows. Merge that actually 
>>> works.
>>> Faster operations. Version large binaries.  Built-in WAN 
>>> optimization
>> and the
>>> freedom to use Git, Perforce or both. Make the move to Perforce.
>>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Plone-developers mailing list
>>> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>>> https://lists.sourceforge.net/lists/listinfo/plone-developers
>>
>> --
>> programmatic  web development
>> di(fh) johannes raggam / thet
>> python plone zope development
>> plone framework  team  member
>> mail: office-//[email protected]
>> web:  http://programmatic.pro
>>    http://bluedynamics.com
>>
>>
> ------------------------------------------------------------------------------
> Subversion Kills Productivity. Get off Subversion & Make the Move to 
> Perforce.
> With Perforce, you get hassle-free workflows. Merge that actually 
> works.
> Faster operations. Version large binaries.  Built-in WAN optimization 
> and the
> freedom to use Git, Perforce or both. Make the move to Perforce.
> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk_______________________________________________
> Plone-developers mailing list
> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/plone-developers

------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk

_______________________________________________
Plone-developers mailing list
Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/plone-developers