Re: How to add a missing upgrade step to plone.app.upgrade

> It might be best to add the upgrade step for the newest version of Plone
4.3 instead of for the version where it should have been added in the first
place

I don't think this is what you'd want in this case.  Essentially previously
hidden portlets appear after the upgrade.  I guess for sites affected
people have simply hidden the portlets manually.  If they subsequently made
them visible again then you don't want to hide them and there's no way of
knowing on a second pass if they are deliberately visible or not.

I have a fix ready which I'll push once the build is passing again


On 13 March 2014 16:05, David Glick (Plone) <david.glick-z4DKO/[email protected]> wrote:

>  Actually Plone 4.3 and Plone 5 both use the master branch of
> plone.app.upgrade, so you don't need to cherrypick anything.
>
> It might be best to add the upgrade step for the newest version of Plone
> 4.3 instead of for the version where it should have been added in the first
> place. That way anyone who has already upgraded past the version where it
> should have been added will still get the change the next time they
> upgrade. However, this needs to be considered on a case by case basis.
>
>
> On 3/13/14, 4:00 AM, Anthony Gerrard wrote:
>
> Hi,
>
>  I just came across this bug whilst working on a client's upgrade from
> Plone 3.3 to Plone 4.3
>
>  https://dev.plone.org/ticket/12286
>
>  I'm going to have to write an upgrade step to fix this so thought I
> might as well add it to the core.
>
>  What's the procedure for retrospectively adding missing steps?
>
>  My plan would roughly be:
>
>  * work on master branch
> * add upgrade step to the v40 folder
> * push changes
> * cherry pick commit back to 4.3 branch
>
>  Does that sound right?  Do I need to create new profile or add the code
> to an existing one?
>
>  Anthony
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!http://p.sf.net/sfu/13534_NeoTech
>
>
>
> _______________________________________________
> Plone-developers mailing listPlone-developers-5NWGOfrQmneRv+LV9MX5ugtCRVl27V+i0wdF1cv0I5s@public.gmane.org://lists.sourceforge.net/lists/listinfo/plone-developers
>
>
>

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech

_______________________________________________
Plone-developers mailing list
Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/plone-developers